aboutsummaryrefslogtreecommitdiffstats
path: root/src/libmsc/ran_msg_a.c
diff options
context:
space:
mode:
authorNeels Hofmeyr <neels@hofmeyr.de>2019-10-05 05:15:25 +0200
committerNeels Hofmeyr <neels@hofmeyr.de>2019-11-01 17:35:17 +0100
commit84ce206ae3e36b7a8623c7fec32203a226812ad2 (patch)
treeb82eb115a9cf73036c5854deb9c6c4f34a1666e6 /src/libmsc/ran_msg_a.c
parent523b92f3aadb9a63e3048f8fee58d380ced7b7dc (diff)
use osmo_sockaddr_str_is_nonzero()
Also regard an RTP port as invalid if the IP address is 0.0.0.0. Achieve this by using osmo_sockaddr_str_is_nonzero() instead of osmo_sockaddr_str_is_set(). Depends: I73cbcab90cffcdc9a5f8d5281c57c1f87b2c3550 (libosmocore) Change-Id: I53ddb19a70fda3deb906464e1b89c12d9b4c7cbd
Diffstat (limited to 'src/libmsc/ran_msg_a.c')
-rw-r--r--src/libmsc/ran_msg_a.c6
1 files changed, 3 insertions, 3 deletions
diff --git a/src/libmsc/ran_msg_a.c b/src/libmsc/ran_msg_a.c
index fa0335c15..fc9a9d73d 100644
--- a/src/libmsc/ran_msg_a.c
+++ b/src/libmsc/ran_msg_a.c
@@ -942,7 +942,7 @@ static struct msgb *ran_a_make_assignment_command(struct osmo_fsm_inst *log_fi,
use_scl = &scl;
/* Package RTP-Address data */
- if (osmo_sockaddr_str_is_set(ac->cn_rtp)) {
+ if (osmo_sockaddr_str_is_nonzero(ac->cn_rtp)) {
struct sockaddr_in rtp_addr_in;
memset(&rtp_addr_in, 0, sizeof(rtp_addr_in));
@@ -1114,7 +1114,7 @@ struct msgb *ran_a_make_handover_request(struct osmo_fsm_inst *log_fi, const str
if (n->classmark)
r.classmark_information = *n->classmark;
- if (osmo_sockaddr_str_is_set(n->rtp_ran_local)) {
+ if (osmo_sockaddr_str_is_nonzero(n->rtp_ran_local)) {
if (osmo_sockaddr_str_to_sockaddr(n->rtp_ran_local, &ss)) {
LOG_RAN_A_ENC(log_fi, LOGL_ERROR,
"Handover Request: invalid AoIP Transport Layer address/port: "
@@ -1139,7 +1139,7 @@ static struct msgb *ran_a_make_handover_request_ack(struct osmo_fsm_inst *caller
.chosen_speech_version = r->chosen_speech_version,
};
- if (osmo_sockaddr_str_is_set(&r->remote_rtp)) {
+ if (osmo_sockaddr_str_is_nonzero(&r->remote_rtp)) {
osmo_sockaddr_str_to_sockaddr(&r->remote_rtp, &ss);
params.aoip_transport_layer = &ss;
}