diff options
| author | Max <msuraev@sysmocom.de> | 2019-01-10 17:25:33 +0100 |
|---|---|---|
| committer | Vadim Yanitskiy <axilirator@gmail.com> | 2019-02-15 02:19:24 +0700 |
| commit | 30fb97aa431d8c8cfcf00e193c809ad1c5567d10 (patch) | |
| tree | 5cd5bc2cdbbec6d8d8056fa6f7a527386bab53ac /src/libmsc/gsm_09_11.c | |
| parent | 114bad8c48bb37d8cdf1b4956a0fd046a3b0783e (diff) | |
transaction: drop meaningless ti_flag of trans_assign_trans_id()
According to GSM 04.07, the TI flag takes one bit and can be
either of the following:
'0'B - transaction is allocated by sender of a message,
'1'B - transaction is allocated by receiver of a message.
Since we store transaction ID in gsm_trans structure, we also store
TI flag (as a part of transaction ID), which in this context means:
'0'B - transaction is allocated by us (OsmoMSC),
'1'B - transaction is allocated by some MS.
In 100% cases, trans_assign_trans_id() is used to assign transaction IDs
to transactions allocated by us (i.e. OsmoMSC) for MT connections. And
there is no need to use it for MO transactions, because they basically
already do contain a valid transaction ID assigned by the MS.
Change-Id: Ie11999900b1789652ee078d34636dcda1e137eb0
Diffstat (limited to 'src/libmsc/gsm_09_11.c')
| -rw-r--r-- | src/libmsc/gsm_09_11.c | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/src/libmsc/gsm_09_11.c b/src/libmsc/gsm_09_11.c index dca315d7f..08721d47c 100644 --- a/src/libmsc/gsm_09_11.c +++ b/src/libmsc/gsm_09_11.c @@ -306,8 +306,7 @@ static struct gsm_trans *establish_nc_ss_trans(struct gsm_network *net, osmo_counter_inc(net->active_nc_ss); /* Assign transaction ID */ - tid = trans_assign_trans_id(trans->net, - trans->vsub, GSM48_PDISC_NC_SS, 0); + tid = trans_assign_trans_id(trans->net, trans->vsub, GSM48_PDISC_NC_SS); if (tid < 0) { LOGP(DMM, LOGL_ERROR, "No free transaction ID\n"); /* TODO: inform HLR about this */ |