diff options
| author | Holger Hans Peter Freyther <zecke@selfish.org> | 2010-05-16 16:45:27 +0800 |
|---|---|---|
| committer | Holger Hans Peter Freyther <zecke@selfish.org> | 2010-06-15 20:24:20 +0800 |
| commit | e1fb5670cda5ba099c24a6656058b98771fa2f3b (patch) | |
| tree | 8f0c01dd719b6de5f6e0951bc600e9a8b2b2eb2e /openbsc | |
| parent | c58da4b374c6a748bda60c6e3068568b8a3f220c (diff) | |
[nat] Remove parameter that is never accessed directly
The msgb needs to be around when we access the parsed structure
but that needs to be guranteed by the caller handing out the parsed
structure.
Diffstat (limited to 'openbsc')
| -rw-r--r-- | openbsc/include/openbsc/bsc_nat.h | 2 | ||||
| -rw-r--r-- | openbsc/src/nat/bsc_nat.c | 2 | ||||
| -rw-r--r-- | openbsc/src/nat/bsc_sccp.c | 2 | ||||
| -rw-r--r-- | openbsc/tests/bsc-nat/bsc_nat_test.c | 2 |
4 files changed, 4 insertions, 4 deletions
diff --git a/openbsc/include/openbsc/bsc_nat.h b/openbsc/include/openbsc/bsc_nat.h index 80d69d196..bcd6f8e96 100644 --- a/openbsc/include/openbsc/bsc_nat.h +++ b/openbsc/include/openbsc/bsc_nat.h @@ -281,7 +281,7 @@ int bsc_nat_filter_sccp_cr(struct bsc_connection *bsc, struct msgb *msg, /** * SCCP patching and handling */ -int create_sccp_src_ref(struct bsc_connection *bsc, struct msgb *msg, struct bsc_nat_parsed *parsed); +int create_sccp_src_ref(struct bsc_connection *bsc, struct bsc_nat_parsed *parsed); int update_sccp_src_ref(struct sccp_connections *sccp, struct bsc_nat_parsed *parsed); void remove_sccp_src_ref(struct bsc_connection *bsc, struct msgb *msg, struct bsc_nat_parsed *parsed); struct sccp_connections *patch_sccp_src_ref_to_bsc(struct msgb *, struct bsc_nat_parsed *, struct bsc_nat *); diff --git a/openbsc/src/nat/bsc_nat.c b/openbsc/src/nat/bsc_nat.c index 65f6eecdb..0fa57135b 100644 --- a/openbsc/src/nat/bsc_nat.c +++ b/openbsc/src/nat/bsc_nat.c @@ -644,7 +644,7 @@ static int forward_sccp_to_msc(struct bsc_connection *bsc, struct msgb *msg) case SCCP_MSG_TYPE_CR: if (bsc_nat_filter_sccp_cr(bsc, msg, parsed, &con_type) != 0) goto exit3; - if (create_sccp_src_ref(bsc, msg, parsed) != 0) + if (create_sccp_src_ref(bsc, parsed) != 0) goto exit2; con = patch_sccp_src_ref_to_msc(msg, parsed, bsc); con->con_type = con_type; diff --git a/openbsc/src/nat/bsc_sccp.c b/openbsc/src/nat/bsc_sccp.c index f77cbefa7..47cd9ce72 100644 --- a/openbsc/src/nat/bsc_sccp.c +++ b/openbsc/src/nat/bsc_sccp.c @@ -82,7 +82,7 @@ static int assign_src_local_reference(struct sccp_source_reference *ref, struct return -1; } -int create_sccp_src_ref(struct bsc_connection *bsc, struct msgb *msg, struct bsc_nat_parsed *parsed) +int create_sccp_src_ref(struct bsc_connection *bsc, struct bsc_nat_parsed *parsed) { struct sccp_connections *conn; diff --git a/openbsc/tests/bsc-nat/bsc_nat_test.c b/openbsc/tests/bsc-nat/bsc_nat_test.c index adc8a197a..ca9fbd4dd 100644 --- a/openbsc/tests/bsc-nat/bsc_nat_test.c +++ b/openbsc/tests/bsc-nat/bsc_nat_test.c @@ -294,7 +294,7 @@ static void test_contrack() fprintf(stderr, "Con should not exist %p\n", con_found); abort(); } - rc = create_sccp_src_ref(con, msg, parsed); + rc = create_sccp_src_ref(con, parsed); if (rc != 0) { fprintf(stderr, "Failed to create a ref\n"); abort(); |