aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorPau Espin Pedrol <pespin@sysmocom.de>2018-04-24 11:46:58 +0200
committerPau Espin Pedrol <pespin@sysmocom.de>2018-04-24 11:47:00 +0200
commit25adebea4cef65c0a530f8ec161d1cc657be2efa (patch)
treef645727f8f902a6ba60fded0000cadb6dba7ffa0
parent4cf452fbd8873aad679e5d09d03e8ab1c7289e55 (diff)
setup_trig_pag_evt: Remove uneeded default case in switch statement
Take the chance to pass a var of type enum instead, so the compiler warns us if a new enum value is added. For instance, if we remove GSM_PAGING_EXPIRED from the switch statement: src/libmsc/gsm_04_08.c:1463:2: warning: enumeration value ‘GSM_PAGING_EXPIRED’ not handled in switch [-Wswitch] switch (paging_event) { ^~~~~~ Change-Id: I65d871704b9636c594dc982200fbe7f7ce6784f5
-rw-r--r--src/libmsc/gsm_04_08.c6
1 files changed, 2 insertions, 4 deletions
diff --git a/src/libmsc/gsm_04_08.c b/src/libmsc/gsm_04_08.c
index 2b8e4c1df..ea5a81aca 100644
--- a/src/libmsc/gsm_04_08.c
+++ b/src/libmsc/gsm_04_08.c
@@ -1456,10 +1456,11 @@ static int setup_trig_pag_evt(unsigned int hooknum, unsigned int event,
{
struct gsm_subscriber_connection *conn = _conn;
struct gsm_trans *transt = _transt;
+ enum gsm_paging_event paging_event = event;
OSMO_ASSERT(!transt->conn);
- switch (event) {
+ switch (paging_event) {
case GSM_PAGING_SUCCEEDED:
DEBUGP(DCC, "Paging subscr %s succeeded!\n",
vlr_subscr_msisdn_or_name(transt->vsub));
@@ -1482,9 +1483,6 @@ static int setup_trig_pag_evt(unsigned int hooknum, unsigned int event,
transt->paging_request = NULL;
trans_free(transt);
break;
- default:
- LOGP(DCC, LOGL_ERROR, "Unknown paging event %d\n", event);
- break;
}
transt->paging_request = NULL;