aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorNeels Hofmeyr <neels@hofmeyr.de>2020-08-19 13:40:33 +0000
committerNeels Hofmeyr <neels@hofmeyr.de>2020-09-08 23:51:47 +0200
commit36b604181c1473df79cd8d56f0c01a4f6dce047c (patch)
treeae5d8aa9e02b0f9e9fce7036d41d721bd9c475f2
parent4a5ba81f7d057373ed44ab66169faa1f9d7b46ea (diff)
fix crash for unknown MI during Paging Responseneels/1.6.2
-rw-r--r--src/libmsc/gsm_04_08.c7
1 files changed, 6 insertions, 1 deletions
diff --git a/src/libmsc/gsm_04_08.c b/src/libmsc/gsm_04_08.c
index b284ccd7a..3594bfc79 100644
--- a/src/libmsc/gsm_04_08.c
+++ b/src/libmsc/gsm_04_08.c
@@ -1185,7 +1185,12 @@ static int gsm48_rx_rr_pag_resp(struct msc_a *msc_a, struct msgb *msg)
vsub = msc_a_vsub(msc_a);
if (!vsub) {
LOG_MSC_A(msc_a, LOGL_ERROR, "subscriber not allowed to do a Paging Response\n");
- msc_a_put(msc_a, MSC_A_USE_PAGING_RESPONSE);
+
+ /* Above MSC_A_USE_PAGING_RESPONSE may already have been removed by a forced release, put that use only
+ * if it still exists. (see msc_a_fsm_releasing_onenter()) */
+ if (osmo_use_count_by(&msc_a->use_count, MSC_A_USE_PAGING_RESPONSE))
+ msc_a_put(msc_a, MSC_A_USE_PAGING_RESPONSE);
+
return -EIO;
}