diff options
| author | Vadim Yanitskiy <axilirator@gmail.com> | 2020-01-25 06:25:12 +0700 |
|---|---|---|
| committer | fixeria <axilirator@gmail.com> | 2020-01-27 18:21:08 +0000 |
| commit | 064a1e0c5444f76d53895022041c0034f649a73e (patch) | |
| tree | 2106a8560ba982594af1a3256bbb77491b25d7d7 | |
| parent | 601af0ca0090eb19cbed4f44d8311991c8b0c903 (diff) | |
msc/sccp_ran.h: fix: do not pass -1 to osmo_rat_type_name()
The problem is that osmo_rat_type_name() calls get_value_string(),
so we first cast -1 to 'const enum osmo_rat_type' and then to
'uint32_t'. Let's rather use OSMO_RAT_UNKNOWN.
Found by GCC with -Wextra in CFLAGS:
warning: operand of ?: changes signedness from ‘int’ to
‘const enum osmo_rat_type’ due to unsignedness
of other operand [-Wsign-compare]
Change-Id: I63ba355102d3cc035ba90121e06aba7cf1776aa0
| -rw-r--r-- | include/osmocom/msc/sccp_ran.h | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/include/osmocom/msc/sccp_ran.h b/include/osmocom/msc/sccp_ran.h index f190d91e3..f84bf614e 100644 --- a/include/osmocom/msc/sccp_ran.h +++ b/include/osmocom/msc/sccp_ran.h @@ -189,14 +189,14 @@ struct sccp_ran_inst; #define LOG_SCCP_RAN_CO(sri, peer_addr, conn_id, level, fmt, args...) \ LOGP((sri) && (sri)->ran? (sri)->ran->log_subsys : DMSC, level, "(%s-%u%s%s) " fmt, \ - osmo_rat_type_name((sri) && (sri)->ran? (sri)->ran->type : -1), conn_id, \ + osmo_rat_type_name((sri) && (sri)->ran ? (sri)->ran->type : OSMO_RAT_UNKNOWN), conn_id, \ peer_addr ? " from " : "", \ peer_addr ? osmo_sccp_inst_addr_name((sri)->sccp, peer_addr) : "", \ ## args) #define LOG_SCCP_RAN_CL_CAT(sri, peer_addr, subsys, level, fmt, args...) \ LOGP(subsys, level, "(%s%s%s) " fmt, \ - osmo_rat_type_name((sri) && (sri)->ran? (sri)->ran->type : -1), \ + osmo_rat_type_name((sri) && (sri)->ran ? (sri)->ran->type : OSMO_RAT_UNKNOWN), \ peer_addr ? " from " : "", \ peer_addr ? osmo_sccp_inst_addr_name((sri)->sccp, peer_addr) : "", \ ## args) |