aboutsummaryrefslogtreecommitdiffstats
path: root/tests
AgeCommit message (Collapse)AuthorFilesLines
2019-04-25osmux: Cleanup of CID alloc pool APIsPau Espin Pedrol1-10/+19
* Cleanup naming to make it far more clear * Drop 2 variables holding CID values (allocated_cid, cid), in favour of 1 value holdinf the value and one bool stating whether the value is used. * Change conn_osmux_allocate_cid to allow allocating either next available CID or a specific one, in preparation for forthcoming patches. This commit can be merged straight away because anyway osmux cannot be enabled in current status (blocked by vty config) and (conn_)osmux_allocate_cid was/is not called anywhere. However, it helps improving code base for future re-introduction of Osmux as it is envisioned. Change-Id: I737a248ac6c74add8e917fe2e2f36779d0f1d685
2019-04-23cosmetic: tests: mgcp_client_test: clean trailing whitespacePau Espin Pedrol1-9/+9
Change-Id: Ie27c0a9bf7a16983f31a07c314b0a602e9fb8999
2019-03-12AMR: Add function to convert between bw-effient and octet aligned modePhilipp Maier2-1/+54
RFC3267 specifies two framing modes for AMR packets. An octet aligned mode is specified where all fields of the AMR packets are aligned to octet boundaries. The second framing mode is the bandwith efficient mode where the fields are directly packed one after another. - add paring/generation functions for related SDP fmtp parameters - add conversion function to convert AMR payload Depends: libosmo-netif I5b5a0fa644d8dbb1f04f9d7e35312683c7b3d196 Change-Id: I622c01874b25f5049d4f59eb8157e0ea3cbe16ba Related: OS#3807
2019-02-06Inactive connection cleanup (disabled by default)Oliver Smith1-0/+4
Add a watchdog timer to connections, and close these connections when the watchdog timer expires. Kick the watchdog whenever RTP messages or the relevant MGCP messages arrive. Add the currently remaining timeout to "show mgcp stats" in the VTY. This feature is disabled by default, as it is incompatible with LCLS (connections in LCLS state appear to be inactive). Enable it with the new "conn-timeout" VTY setting. In general, this feature can be used to work around interoperability problems causing connections to stay open forever, and slowly exhausting all available ports. This happened for various reasons already. MDCX is the only relevant MGCP message: - CRCX creates the conn and timer - DLCX deletes the conn and timer - MDCX is the only remaining supported MGCP message that indicates a CI - Can't easily generically parse a CI for all MGCP messages, parsing is done in handle_modify_con(). Related: OS#3429 Change-Id: I18886052e090466f73829133c24f011806cc1fe0
2019-01-03mgcp_client: make domain part of endpoint configurableNeels Hofmeyr1-0/+2
So far, both osmo-msc and osmo-bsc always pass endpoint names of the form '...@mgw' to osmo-mgw. Allow configuring the 'mgw' part. Note that the actual way to pass a differing name is to pass a composed 'rtpbridge/*@foo' to mgcp_msg_gen() in the struct mgcp_msg. So this merely adds a common VTY config for the domain name part, changes to clients are necessary. - add mgcp_client_rtpbridge_wildcard() (useful for AoIP endpoints) - add mgcp_client_endpoint_domain() (useful for SCCPlite endpoints) - add mgcp client vty cfg 'mgw endpoint-domain NAME' Rationale: reading pcaps becomes so much easier when each of osmo-bsc and osmo-msc address their MGW with differing domain names. Otherwise, both will have a '0@mgw' endpoint and it gets really confusing. Also: our MGCP clients osmo-bsc and osmo-msc use code dup to compose the initial 'rtpbridge/*@mgw' rtpbridge wildcard. It should be defined by this API instead. This will be used by: * osmo-msc I87ac11847d1a6d165ee9a2b5d8a4978e7ac73433 * osmo-bsc I492023e9dca0233ec0a077032455d9f2e3880f78 After these, with according configuration, there can be a '0@bsc' and a '0@msc' endpoint on two separate osmo-mgw instances: osmo-mgw-for-bsc.cfg: mgcp domain bsc osmo-bsc.cfg: msc 0 mgw endpoint-domain bsc osmo-mgw-for-msc.cfg: mgcp domain msc osmo-msc.cfg: msc mgw endpoint-domain msc There can also be '0@bsc' and '1@msc' endpoints on one single osmo-mgw instance with: osmo-mgw.cfg: mgcp domain * and same osmo-{bsc,msc}.cfg as above. (By default, everything will still use '@mgw') Change-Id: Ia662016f29dd8727d9c4626d726729641e21e1f8
2018-12-19mgcp_client: drop a bunch of dead codeNeels Hofmeyr3-196/+0
Remove public API that makes no sense anymore and is dead code. I see the dropped API as a dead-end initial misconception of the early mgcp client, and it doesn't really make sense to drag this stuff along. It has not been used by osmo-msc,-bsc for a long time now, and just confuses the reader. It is public API, yes, and older versions of osmo-msc / osmo-bsc will not be able to compile against this, but even if it did, the resulting MGCP client would not work with the current osmo-mgw: this API is still based on the premise that the MGCP client dictates the MGW endpoint numbers, a concept that cannot be used with the current osmo-mgw. Instead, osmo-mgw expects a wildcarded endpoint upon CRCX and assigns its own endpoint names. Also, the bts-base configuration is unused and a legacy of when osmo-bsc_mgcp had explicit BTS and CN sides. Change-Id: I98a9f1f17a1c4ab20cea3b08c7d21663592134d6
2018-10-16mgcp: Log endpoint nr consistently as hexPau Espin Pedrol1-2/+2
Port from openbsc 078905a0603c91b227854abfa01c9e24143e39a1. Change-Id: Idcb40e6fd561b24e111afe7463f44c43c530fac5
2018-09-07cosmetic: mgcp_test: fix get_conn_id_from_response()Neels Hofmeyr1-36/+31
This function is implemented in such a weird way that I couldn't stop myself from rewriting it. Change-Id: Ib9b13d7b0e64f8ae25a7b69cbb385e7fad33d02b
2018-09-07mgcp_conn_get(): match conn Id ('I:') despite leading zerosNeels Hofmeyr2-0/+12
The Connection Identifier is defined as a hex string, so clients may send the ID back with or without leading zeros. Ignore all leading zeros when comparing. A specific SCCPlite MSC is observed to DLCX with Connection Identifier with leading zeros removed, which would mismatch pefore this patch. Extend test_conn_id_matching() in mgcp_test.c to include leading zero tests. Now, mgcp_conn_get() would match a valid id with *any* amount of leading zeros, even if that far surpasses the permitted conn id length. Valid lengths of incoming conn ids should be and is checked elsewhere. Related: OS#3509 Change-Id: If55a64a2da47b6eff035711c08e4114d70dbec91
2018-09-07mgcp_conn_get(): compare conn Id ('I:') case insensitivelyNeels Hofmeyr2-0/+39
The Connection Identifier is defined as a hex string, so clients may send the ID back in lower case. Convert to upper case before comparing. A specific SCCPlite MSC is observed to DLCX with Connection Identifier in lower case, which would mismatch pefore this patch. Add test_conn_id_matching() in mgcp_test.c to verify case insensitivity. Cosmetic: use strcmp(), not strncmp(). In the presence of a terminating nul as we can assume here, this makes no functional difference, but it clarifies the code. Related: OS#3508 Depends: Ib0ee1206b9f31d7ba25c31f8008119ac55440797 (libosmocore) Change-Id: I8e52278c3abe9e9c8c848c2b1538bce443f68a43
2018-09-06Remove libosmo-legacy-mgcp and osmo-bsc-mgcpPau Espin Pedrol9-3172/+0
They are only used by openbsc.git programs and belong there. Change-Id: Id31bef052d3f9b8aada1824d6f7f995ebd39bbfd
2018-09-03fix mgcp_verify_ci(): off-by-one in max len checkNeels Hofmeyr2-0/+20
MGCP_CONN_ID_MAXLEN actually includes a terminating nul, so we need to compare strlen() against MGCP_CONN_ID_MAXLEN-1. Log the length if it is too long. Add MDCX_TOO_LONG_CI test to mgcp_test.c, testing a conn id of 33 characters. Before this patch, the test returns error code 515 meaning "not found", while now it returns 510 meaning "invalid", showing the off-by-one. Same is illustrated by the error log ("not found" before, "too long" now), but the error log is not verified by mgcp_test.c. Change-Id: I8d6cc96be252bb486e94f343a8c7cae641ff9429
2018-09-03mgcp_client: error on too long conn idNeels Hofmeyr2-16/+2
Instead of just silently truncating the conn ID if it is too long, rather verify its length and return an error where applicable. Adjust expected test output. Change-Id: If2a1aab1f13e771a6705c430e3c75bd42477a23b
2018-09-03mgcp_client_test: test long conn_idNeels Hofmeyr2-0/+140
Add a full length (32 characters according to spec) conn ID in a CRCX response, as well as a too long one. The too long one is currently silently truncated, a subsequent patch will improve on that (If2a1aab1f13e771a6705c430e3c75bd42477a23b). Change-Id: I5f2d52f086ea2d330fcce88a176488ace972bf79
2018-09-03mgcp_client_test: also verify received conn_idNeels Hofmeyr2-0/+2
Include the parsed conn_id in the response cb printout to verify them in mgcp_client_test.ok. Change-Id: I6b9b18d4d0867febd75a4d29f8a2fcdf0553ae4c
2018-09-03mgcp_client_test: use "\r\n\r\n" instead of "\n\n"Neels Hofmeyr2-6/+6
The separator between MGCP and SDP section is typically "\r\n\r\n". For some reason the test so far used "\n\n" instead, rather use the standard separator. Change-Id: I41c73722e5fae00663bcf96de0b57b7155809a06
2018-09-03mgcp_client_test: cosmetically re-arrange reply_to() argsNeels Hofmeyr1-5/+6
I want to test arbitrary length Conn IDs ('I:'), and hence don't want to pass the conn_id as int, but rather just include it in the message string. Prepare for that by eliminating the extra conn_id arg and just pass a params string. Change-Id: Ib2e718dda3aa1f6e9979dee823d973dd002e2318
2018-08-30mgcp_test: fix get_conn_id_from_response() CI lengthNeels Hofmeyr1-1/+4
This function is set on conn ID length of 32 characters. Make it detect a shorter length also when parsing 'o=-' headers. Before, this failed to recognize a space as the end of the conn ID, now sees any non-hex char as end. Related: OS#3507 Change-Id: I762c273bac172acb6d0aae6ea6267603ab654cbf
2018-08-30mgcp_test: fix log of conn_id presenceNeels Hofmeyr2-27/+27
Flip logic to accurately log whether an 'I:' is included, instead of logging the opposite. Note that it isn't possible to log the actual conn ID, because they are random and differ in every test run, which would collide with the fixed expected output file mgcp_test.ok. Change-Id: Idcd731b9daf618b97d8f7e6a776266071cd29e08
2018-08-28X-Osmo-IGN: rather parse items by token, not charNeels Hofmeyr2-2/+2
Adjust the X-Osmo-IGN parsing to use string tokens instead of parsing single characters. Reconsidering the first implementation as a poor choice, rather specify the format of X-Osmo-IGN as any-length string tokens separated by spaces, which is more flexible and more future proof. See also osmo-gsm-manuals If15a88c3b5b40fd1d24ad0f94f3231f678669ab1 which defines the X-Osmo-IGN format as string tokens, matching this patch. In mgcp_test, add an unknown X-Osmo-IGN item. Though the output is not checked by the testsuite.at, running manually shows the error log about the unkown X-Osmo-IGN item. Change-Id: Ia6fe5ead4b601931c1bf41b29fc1b237aac37d2c
2018-08-25add X-Osmo-IGN MGCP header to ignore CallIDNeels Hofmeyr4-1/+70
The format is CRCX ... C: ... M: ... X-Osmo-IGN: C So far the only ignorable element is C, i.e. the CallID. Any other items may be added in the future. (I initially intended to also add '@' to ignore the endpoint name's domain part, but in the osmo-mgw code base the domain part is verified long before any additional headers are even parsed, so sparing that refactoring for now.) The intention is that osmo-bsc will issue "X-Osmo-IGN: C" for all SCCPlite calls, because we are unable to retrieve the CallID that the MSC sends to osmo-mgw for the network side of the endpoint. Testing with a specific SCCPlite MSC, I actually observe that all CallIDs are 1, even for concurrent calls. So, an alternative hacky solution would have been to always pass CallID == 1 for SCCPlite connections from osmo-bsc. Related: I257ad574d8060fef19afce9798bd8a5a7f8c99fe (osmo-bsc) Change-Id: Id7ae275ffde8ea9389270cfe3db087ee8db00b51
2018-08-02mgcp_test: release endpoints after usePhilipp Maier1-0/+4
The test function test_multilple_codec() in mgcp_test.c creates a lot of connections, but it never releases them. Just freeing the cfg object is not enough since the UDP ports stay open and this may interfere with other tests that also create connections (port numbers). - Make sure all endpoints are released when test_multilple_codec() is done. Change-Id: Ic13b4368162149ec36c93f4188fa4c71166e08d5
2018-07-31mgcp_network: translate payload type numbers in RTP packetsPhilipp Maier1-0/+95
Since no transcoding is in place osmo-mgw forwards the incoming rtp packets as they are (there may be minor modifications of the header) from an ingress connection to an egress connection. This works without problems as long as both connections use the same payload type. For IANA defined fixed payload type numbers this is usually the case, but for dynemic payload type numbers both ends may set up the same codecs but with different payload type numbers. When different payload type numbers are set up, and the packet is passed through without modification, it will have the wrong payload type when it is sent. The receiving end may then toss the packet since it expects packets with the payload type it has configured. The machanism, which is introduced with this patch looks up actual codec inside the struct data of the ingress connection and then looks for the matching codec in the struct data of the egress connection. When it finds the codec there it looks up the payload type of this codec. The header of the RTP packet is then patched with the correct payoad type. - Add function mgcp_codec_pt_translate() to look up the payload type - Add unit-test for function mgcp_codec_pt_translate() - Add payload type translation to mgcp_network.c Change-Id: I3a874e59fa07bcc2a67c376cafa197360036f539 Related: OS#2728 Related: OS#3384
2018-07-05stats: replace packet statistic counters with libosmocore rate countersPhilipp Maier1-10/+33
In struct mgcp_rtp_end one finds unsigned int counters. Those should be replaced with libosmocore rate counters - replace packets_rx, octets_rx, packets_tx, octets_tx and dropped_packets with libosmocore rate counters. Change-Id: I47c5c9006df5044e59ddebb895e62adb849d72d5 Related: OS#2517
2018-06-23client: add features to generate and parse codec informationPhilipp Maier3-23/+266
The current implementation does not support any way to influence the codec that is negotiated via SDP or LCO. The client statically negotitates AMR on an invalid payload type number. Also we ignore any codec information in the responses. - Add struct members to allow setting of user defined codec information. - Add struct members to retrieve parsed codec info from responses. - Add code to generate codec information in SDP - Add code to parse SDP codec info in MGCP responses Change-Id: I78e72d41b73acfcb40599a0ff4823f17c3642059 Related: OS#2728 Related: OS#3334
2018-06-23mgw: clean up codec negotiation (sdp)Philipp Maier2-20/+61
The codec negotiation via SDP is currently in a neglected state. Also osmo-mgw does some kind of codec decision wile the SDP is parsed, the result is information for one codec, even when there are multiple codecs negotiated. This is problematic because we loose all information about alternate codecs while we parse. This should be untangled and the information should be presevered. Also we are not really capable picking a default. Wehen we do not supply any codec information (not even LCO), then we should pick a sane default codec. - separate the codec decision from the sdp parser and concentrate codec related code in a separate c file - add support for multiple codecs in one SDP negotiation - do not initalize "magic" codec defaults during conn allocation - do not allow invalid payload types, especially not 255. When someone tries to select an invalid payload type, do not fail hard, just pick a sane default. - handle the codec decision in protocol.c, pick a sane default codec when no (valid) codec has been negotiated (no LCO, no SDP) Change-Id: If730d022ba6bdb217ad4e20b3fbbd1114dbb4b8f Closes: OS#2658 Related: OS#3114 Related: OS#2728
2018-06-06protocol: reject illegal lco optionsPhilipp Maier2-0/+118
At the moment osmo-mgw will accept multiple lco options. (e.g. p:10, a:PCMU, p:10) If LCO appear multiple times, than the first appearance of will be parsed and used, all following appearances will be ignored. However, having multiple appearances of LCO is illegal and affected requests should be rejected. Also osmo-mgw should reject illegal formatted LCO strings - make sure that multiple appearances of LCOs will be rejected - make sure that illegal formated LCOs are rejected - add testcases with garbeled LCO and valid LCO examples Change-Id: Iae2fddfa5f2bcfc952f8ab217b3056694e5f7812 Closes: OS#3119
2018-05-25sdp: remove unused alt_codec field from struct mgcp_rtp_endPhilipp Maier1-7/+0
The alt_codec field is not used anywhere in the code - remove unused alt_codec field Change-Id: I5ff2899e3e61f33eb86f284b50ad8a94a949ed16 Related: OS#3114
2018-05-16stats: use libosmocore rate counter for in/out_stream.err_ts_counterPhilipp Maier1-7/+14
The two counters: in_stream.err_ts_counter and out_stream.err_ts_counter are still handcoded. To make them better accessible they should be replaced with libosmocore rate counters. - replace state.in_stream.err_ts_counter with libosmocore rate counter - replace state.out_stream.err_ts_counter with libosmocore rate counter Change-Id: I9fbd65bf2f4d1e015a05996db4c1f7ff20be2c95 Related: OS#2517
2018-04-21Revert "stats: use libosmocore rate counter for in/out_stream.err_ts_counter"Alexander Couzens1-12/+5
This reverts commit 7181cc1f026a0b63a061296aba4e10a9cadaf2c8. The tests are broken on i686, arm (non 64bit systems). Change-Id: I15f3c78f8410d709733ed5692ba94ba17559d7e1
2018-04-17stats: use libosmocore rate counter for in/out_stream.err_ts_counterPhilipp Maier1-5/+12
The two counters: in_stream.err_ts_counter and out_stream.err_ts_counter are still handcoded. To make them better accessible they should be replaced with libosmocore rate counters. - replace state.in_stream.err_ts_counter with libosmocore rate counter - replace state.out_stream.err_ts_counter with libosmocore rate counter Change-Id: I67aa7a8602f60366ef3ba2c5b1319b1b85719f64 Related: OS#2517
2018-04-01use osmo_init_logging2() with proper talloc ctxNeels Hofmeyr4-6/+9
Change-Id: I3e2a9aef5242efdf11a64536f79099a6e9cec53f
2018-02-22compiler warning: ignore deprecated in mgcp_client_test.cNeels Hofmeyr1-0/+2
mgcp_msg_crcx() causes deprecation warning, but it's fine for a unit test to use deprecated API. Change-Id: Iba6d0c9c729367e00a9ab7fff7c89007d336e59d
2018-02-21mgcp_client: detect SDP section-start parsing errorsNeels Hofmeyr2-14/+8
After call to mgcp_find_section_end(), actually check the proper variable to evaluate its return value. Show in mgcp_client_test output that the parsing errors are fixed, and enable the assertion that no tests should fail. Change-Id: I62a2453cd9e2e7d5408423161fa65ec9c9989f98
2018-02-21mgcp_client: show failure by MGCP SDP section parsing testNeels Hofmeyr3-0/+180
To show how the current code fails, add test_sdp_section_start() to mgcp_client_test.c, and temporarily accept failing output. This will be fixed in change I62a2453cd9e2e7d5408423161fa65ec9c9989f98. Change-Id: I5c6d3566b8f6dbf04c0cd8b127423f5295c19f8d
2018-02-20mgcp_stat: Don't print osmux stats if it is offPau Espin Pedrol2-2/+3
Otherwise we get Osmux stats during a session using RTP, which is confusing. Change-Id: I6fcd680a073fbf8769488ffa2b2b32098c87edf4
2018-02-20legacy: mgcp_protocol: Don't print osmux stats if it is offPau Espin Pedrol1-1/+3
Otherwise we get Osmux stats during a session using RTP, which is confusing. Forward-ported from openbsc e39e18992a3b966581f06fa632d6342643996aaa. Change-Id: I9031350242dd37ce255631c20eed33976887faa6
2018-02-05Turn libosmo-mgcp into local, non-installed libraryHarald Welte1-1/+4
This is an internal library simmilar to 'libmsc' in osmo-msc, which we don't expect to be used by other programs except osmo-mgw. Hence, there's no need to install it as a shared library, which introduces requirements about ABI/API stability and the like. osmo-bsc_nat uses libosmo-legacy-mgcp, and once we should rewrite osmo-bsc_nat, we might need some of the libosmo-mgcp related functions, but at this point it's unclear what exactly would be needed and if current libosmo-mgcp can provide that. As needed, we can introduce a related shared library at that point. Change-Id: Iba0a2c9c694e360356ac2ca584e97795281c6198
2018-02-05cosmetic: rename mgcp_ep.c/h to mgcp_endp.c/hPhilipp Maier1-1/+1
The short term of endpoint has always been "endp" througout the whole project and not "ep". - rename mcgp_ep.c to mgcp_endp.c - rename mgcp_ep.h to mgcp_endp.h Change-Id: Id52047bb2d0407655ac272c858ed3412b8ae9e6d
2018-02-05cosmetic: rename mgcp_release_endp to mgcp_endp_releasePhilipp Maier1-3/+3
In order to allow clean prefixes for future endpoint related functions the "rlease" should be moved to the end of the function name. - rename mgcp_release_endp to mgcp_endp_release Change-Id: I22e938e702f57ad76d38c9f4a1370b110ac1ba11
2018-01-31client: fix sdp parameter orderingPhilipp Maier1-2/+2
The parameter ordering of the client responses does not match the ordering as proposed by by RFC2327, Chapter 6. SDP Specification - reorder generated SDP parameters so that they match RFC2327 Change-Id: I63cac2ebc982ffead92703c22bf68c7aafa7936c
2018-01-26protocol: fix missing carriage returnPhilipp Maier1-13/+13
Some of the line breaks lack the \r character, which leads to an inconsistancy. While our software and even wireshark does ignore the problem, other third party implementations might reject those messages. - Add the missing \r characters to make the message format consistant. Change-Id: I0cd80afae65accd3b4ddc5d82e5d30385879141c
2018-01-26mgcp: permit wildcarded endpoint assignment (CRCX)Philipp Maier1-19/+28
The mgcp protocol in general allows wildcarded endpoints on CRCX. osmo-mgw does not support this feature yet. - when the endpoint name contains a wildcard character, search a free endpoint automatically - return the resulting endpoint name in the parameter section of the mgcp response - add parsing support for the returned endpoint names - Be more concious about the parameters that are returned with each response. Do not unnecessarily attach known parameters. Return the connection ID only on CRCX commands. Only return the endpoint ID on CRCX commands that are wildcarded. Change-Id: Iebc95043569191b6f5fbc8fe266b13fcfcab2e48 related: OS#2631
2018-01-26client: add missing mandatory SDP fieldsPhilipp Maier1-0/+4
The mcgp message generator function mgcp_msg_gen() lacks support for the mandatory SDP fields (v)ersion, (o)rigin, (s)ession and (t)ime. - Automatically generate the missing fields when SDP is generated. Change-Id: I5fbc31a17e8ac10c7cc5dbc31357b61e8920aaa5 Related: OS#2837
2018-01-19mgcp: make domain name configurablePhilipp Maier2-8/+8
At the moment the MGW has a fixed domain name string that is not even checked properly. - Make domain name configurable, use the current "mgw" string as defualt to maintain compatibility - Check the domain name with each request. If the endpoint contains an unexpected domain name, the request must be rejected. Change-Id: Ia91ac428ba83ac1f9b52a0ec8dbf00ef7876da9e
2017-12-28centralize handling of common errors like "endpoint not found"Harald Welte1-1/+1
Previously we * did not distinguish between the cause of errors in mgcp_header_parse * common errors were not handled in mgcp_handle_message() but in individual per-verb functions Let's centralize the handling of generating error responses and remove that burden from the individual per-verb handler functions. Change-Id: I463b27306e10ae3b021583ed102977e7299e5e66
2017-12-25mgcp_rtp_end: Group statistics members into 'stats' sub-structHarald Welte1-1/+1
Change-Id: I4e0ecdcd9a75fe08abc55b730780c01617f3d4af
2017-12-25mgcp_rtp_state: grup 'stats' members into sub-structureHarald Welte1-18/+18
Change-Id: I92a1bead01c6b85bf237b6edf64a1b76b9e97c78
2017-12-04mgcp_test: fix possible double freePhilipp Maier1-1/+2
Change-Id: I2d044382c0bb66e190400e3397449c3f2387359a
2017-12-04mgcp_test: add returncode checkPhilipp Maier2-3/+33
The returncode of get_conn_id_from_response() is unchecked, which is intentional since some of the test messages will intentionally cause this function to fail (the response does not inclde a connection identifier). This means it makes no sense to assert this function to a fixed value. In order to spot regressions better print a log message depending on the return code. Change-Id: I9bce9ca39b7751b557374b7ab57c6c9005bcdb7d Fixes: Coverity CID#180534
generated by cgit v1.2.3 (git 2.25.1) at 2024-09-25 00:21:15 +0000