diff options
| author | Pau Espin Pedrol <pespin@sysmocom.de> | 2019-06-26 12:23:02 +0200 |
|---|---|---|
| committer | Pau Espin Pedrol <pespin@sysmocom.de> | 2019-07-03 12:29:42 +0200 |
| commit | 17058484d199e053ef6e6166972361e86ad21d4b (patch) | |
| tree | 5568dd1d5ce3cd397cec42670fa0880e9e3a420f | |
| parent | 166077ea4895a136d68bbe7912a3df78dfbb5103 (diff) | |
mgw: Support receiving uppercase connection mode
MGCP RFC3435 (https://tools.ietf.org/html/rfc3435) states almost all
text has to be handled in a case-insensitive way, except SDP parts.
Related: OS#4001
Change-Id: I4da93dfc69b5585a197a7e201a1afb72c2f97030
| -rw-r--r-- | src/libosmo-mgcp/mgcp_msg.c | 8 | ||||
| -rw-r--r-- | tests/mgcp/mgcp_test.c | 2 | ||||
| -rw-r--r-- | tests/mgcp/mgcp_test.ok | 2 |
3 files changed, 6 insertions, 6 deletions
diff --git a/src/libosmo-mgcp/mgcp_msg.c b/src/libosmo-mgcp/mgcp_msg.c index 59e0e91da..44589d1b3 100644 --- a/src/libosmo-mgcp/mgcp_msg.c +++ b/src/libosmo-mgcp/mgcp_msg.c @@ -91,13 +91,13 @@ int mgcp_parse_conn_mode(const char *mode, struct mgcp_endpoint *endp, if (!endp) return -1; - if (strcmp(mode, "recvonly") == 0) + if (strcasecmp(mode, "recvonly") == 0) conn->mode = MGCP_CONN_RECV_ONLY; - else if (strcmp(mode, "sendrecv") == 0) + else if (strcasecmp(mode, "sendrecv") == 0) conn->mode = MGCP_CONN_RECV_SEND; - else if (strcmp(mode, "sendonly") == 0) + else if (strcasecmp(mode, "sendonly") == 0) conn->mode = MGCP_CONN_SEND_ONLY; - else if (strcmp(mode, "loopback") == 0) + else if (strcasecmp(mode, "loopback") == 0) conn->mode = MGCP_CONN_LOOPBACK; else { LOGPCONN(conn, DLMGCP, LOGL_ERROR, diff --git a/tests/mgcp/mgcp_test.c b/tests/mgcp/mgcp_test.c index c67b9d53b..5a14bdf8b 100644 --- a/tests/mgcp/mgcp_test.c +++ b/tests/mgcp/mgcp_test.c @@ -165,7 +165,7 @@ static void test_strline(void) #define MDCX4_PT1 \ "MDCX 18983217 1@mgw MGCP 1.0\r\n" \ - "M: sendrecv\r" \ + "M: SENDRECV\r" \ "C: 2\r\n" \ "I: %s\r\n" \ "L: p:20-40, a:AMR, nt:IN\r\n" \ diff --git a/tests/mgcp/mgcp_test.ok b/tests/mgcp/mgcp_test.ok index 08ea43827..358a85c5c 100644 --- a/tests/mgcp/mgcp_test.ok +++ b/tests/mgcp/mgcp_test.ok @@ -125,7 +125,7 @@ Testing MDCX4_PT1 creating message from statically defined input: ---------8<--------- MDCX 18983217 1@mgw MGCP 1.0
-M: sendrecv
C: 2
+M: SENDRECV
C: 2
I: %s
L: p:20-40, a:AMR, nt:IN
|