diff options
| author | Neels Hofmeyr <nhofmeyr@sysmocom.de> | 2016-04-25 14:47:26 +0200 |
|---|---|---|
| committer | Neels Hofmeyr <nhofmeyr@sysmocom.de> | 2016-04-25 15:25:12 +0200 |
| commit | 9246cc9e1e4c9fab62781c987b58dd1bf1f86601 (patch) | |
| tree | e4a9f36e8e50242cdc7a24e91181ac512aa56963 /src | |
| parent | 8f62106d5d094f71511928a5eb0674d60838c896 (diff) | |
cosmetic: comments, log typo, explicit pointer
Fix log typo 'REGSITER' and add some comments on UE Register with TMSI.
The container_pair struct starts with 'list', so passing the container_pair
pointer is equivalent to passing the list; but instead, explicitly mention the
list member to avoid confusion.
Diffstat (limited to 'src')
| -rw-r--r-- | src/hnbgw.h | 2 | ||||
| -rw-r--r-- | src/hnbgw_hnbap.c | 6 | ||||
| -rw-r--r-- | src/ranap_msg_factory.c | 2 |
3 files changed, 7 insertions, 3 deletions
diff --git a/src/hnbgw.h b/src/hnbgw.h index d2d4b09..a7a6f9a 100644 --- a/src/hnbgw.h +++ b/src/hnbgw.h @@ -101,6 +101,8 @@ struct ue_context { /*! Unique Context ID for this UE */ uint32_t context_id; char imsi[16+1]; + /* TODO: track TMSI, for HNBAP UE Register Request with TMSI, + * seen with ip.access nano3G femto cell */ /*! UE is serviced via this HNB */ struct hnb_context *hnb; }; diff --git a/src/hnbgw_hnbap.c b/src/hnbgw_hnbap.c index 971e97e..246c983 100644 --- a/src/hnbgw_hnbap.c +++ b/src/hnbgw_hnbap.c @@ -123,7 +123,7 @@ static int hnbgw_rx_hnb_deregister(struct hnb_context *ctx, ANY_t *in) if (rc < 0) return rc; - DEBUGP(DHNBAP, "HNB-DE-REGSITER cause=%ld\n", + DEBUGP(DHNBAP, "HNB-DE-REGISTER cause=%ld\n", ies.cause); hnbap_free_hnbde_registeries(&ies); @@ -184,7 +184,9 @@ static int hnbgw_rx_ue_register_req(struct hnb_context *ctx, ANY_t *in) ies.uE_Identity.choice.iMSIESN.iMSIDS41.size); break; default: - LOGP(DHNBAP, LOGL_NOTICE, "UE-REGISTER-REQ without IMSI?!?\n"); + LOGP(DHNBAP, LOGL_NOTICE, "UE-REGISTER-REQ without IMSI\n"); + /* TODO: this is probably a TMSI registration. Store TMSIs + * and look them up to accept UE Registration. */ return -1; } diff --git a/src/ranap_msg_factory.c b/src/ranap_msg_factory.c index 6cf997d..7e03b13 100644 --- a/src/ranap_msg_factory.c +++ b/src/ranap_msg_factory.c @@ -814,7 +814,7 @@ struct msgb *ranap_new_msg_rab_assign_data(uint8_t rab_id, uint32_t gtp_ip, uint RANAP_ProtocolIE_ContainerPair_t *container_pair = CALLOC(1, sizeof(*container_pair)); /* Add the pair to the list of IEs of the RAB ass.req */ - ASN_SEQUENCE_ADD(container_pair, pair); + ASN_SEQUENCE_ADD(&container_pair->list, pair); /* Add the pair to the list of IEs of the RAB ass.req */ ASN_SEQUENCE_ADD(&ies.raB_SetupOrModifyList.list, container_pair); |