aboutsummaryrefslogtreecommitdiffstats
AgeCommit message (Collapse)AuthorFilesLines
2019-06-19gsup_router.c: gsup_route_find(): support blobneels/gsup_routerOliver Smith1-2/+8
Do not require the blob (addr, addr_len) passed to gsup_route_find() to be nul-terminated. We already have the length, so the nul-termination is redundant. This is needed for the upcoming gsup message forwarding patch [1]: we want to be able to directly pass non-nul-terminated source and destination name blobs to gsup_route_find(). I have looked into fixing all code that calls gsup_route_find() to never pass a nul-terminated blob combination. But this is a can of worms, because it involves both gsup client and server code. Wireshark shows that clients are sending the nul-terminated string in TLV IEs of IPA messages. The server assumes that this is the case in various places. So we would need to fix it in both (server and client), but then we would lose backwards compatibility with old servers and clients. [1]: change-id Ia4f345abc877baaf0a8f73b8988e6514d9589bf5 Related: OS#3793 Change-Id: I01a45900e14d41bcd338f50ad85d9fabf2c61405
2019-06-17manuals: Update vty documentationDaniel Willmann1-23/+276
Related: OS#1700 Change-Id: Ia650ec9ab97dcb64e4b701328bc7e88d691d427a
2019-06-17manuals: Add script to update vty/counter documentation from dockerDaniel Willmann2-0/+18
Related: OS#1700 Change-Id: Id57c34214396b02fafa55da223764748086290e8
2019-06-11rx_check_imei_req(): fix IMEI bounds checkingOliver Smith1-7/+17
IMEIs (without the checksum) always have 14 digits. Replace the previous check (length <= 14) with a proper one (length == 14) and set the buffer to the right size. While at it, add the return code of gsm48_decode_bc_number2() to the error log message. I have tested with new TTCN3 tests, that the length check is working properly now. Related: OS#2541 Change-Id: I060a8db98fb882e4815d1709a5d85bc0143a73a6
2019-06-04db_hlr: zero-initialize "struct tm"Oliver Smith2-4/+2
The last LU time gets read from the database as string, parsed with strptime to "struct tm", and then gets converted to time_t with mktime. A recent behavior change in glibc's mktime implementation unconvered, that we don't have tm.tm_isdst (daylight saving time) set properly. As "struct tm" was not initialized, and strptime did not write to tm_isdst, it was set to a random value. When it was not 0, db_test failed on UTC systems with a more recent glibc (e.g. Ubuntu 19.04). Fix this by zero-initializing "struct tm" and remove the previous workaround that made db_test pass on UTC systems. Related: OS#4026 Change-Id: Iebbbe42fc5cd43324206d9433ede67b39251389c
2019-06-03db_test: set timezone to work around mktime bugOliver Smith1-1/+3
Apply workaround for db_test failure on ubuntu 19.04 in OBS. When the timezone is set to UTC (default in OBS), and the glibc version is 2.29, the test case is failing sometimes (not always) with the following errors in the test log: DAUC Cannot convert LU timestamp '2019-05-26 03:05:03' to time_t: Value too large for defined Force the timezone to be CET when running the test, so it passes again. I found this workaround in a Fedora bugreport [1], and tested with an ubuntu 19.04 system running in docker, that setting the environment variable like this makes the test pass 25 times in a row. Without it, it fails every two or three times. Then I verified in my OBS namespace, that the test also passes in OBS again. [1] https://bugzilla.redhat.com/show_bug.cgi?id=1653340 Related: OS#4026 Change-Id: Ic8080ba1914bb364169ab0c563b132a4ab9a9aab
2019-05-29debian: create -doc subpackage with pdf manualsOliver Smith4-2/+18
I have verified, that the resulting debian packages build in my own OBS namespace (see the -doc packages): https://download.opensuse.org/repositories/home:/osmith42/Debian_9.0/all/ https://build.opensuse.org/project/show/home:osmith42 Depends: Ib7251cca9116151e473798879375cd5eb48ff3ad (osmo-ci) Related: OS#3899 Change-Id: I4a327bac68769892634236c573c313c7859c6199
2019-05-25src/hlr.c: fix deprecation warning: use gsm48_decode_bcd_number2()Vadim Yanitskiy1-1/+1
Change-Id: I84fc1a0a6a334805b5dc1cef994f70b01a5ffcd4
2019-05-25src/db.h: use GSM23003_MSISDN_MAX_DIGITS for MSISDN buffer sizeVadim Yanitskiy1-1/+1
Change-Id: I253e6a04a77c29f62d3c696515d115f8a829283b Depends on: Idc74f4d94ad44b9fc1b6d43178f5f33d551ebfb1
2019-05-19Document subscribers create on demand featureOliver Smith1-0/+21
Add a new section in the subscribers chapter, with detailed explanation of the use cases and related OsmoHLR and OsmoMSC configuration. Related: OS#2542 Change-Id: I2dd4a56f7b8be8b5d0e6fc32e04459e5e278d0a9
2019-05-19Create subscribers on demandOliver Smith5-0/+186
Add a new vty option and allow to optionally generate a random msisdn, as well as setting the default NAM: subscriber-create-on-demand (no-msisdn|<3-15>) (none|cs|ps|both) Thanks to Vadim for the random MSISDN patch [1], which was squashed into this one. [1] Change-Id: I475c71f9902950fa7498855a616e1ec231fad6ac Depends on: Idc74f4d94ad44b9fc1b6d43178f5f33d551ebfb1 (libosmocore) Change-Id: I0c9fe93f5c24b5e9fefb513c4d049fb7ebd47ecd Related: OS#2542
2019-05-13db_hlr.c: add db_subscr_exists_by_msisdn()Vadim Yanitskiy5-0/+42
Check if a subscriber exists without generating an error log entry if it does not. This is cheaper than db_subscr_get_by_msisdn(), as it does not fetch the subscriber entry. subscriber-create-on-demand will use this function to generate a random unique MSISDN for new subscribers. Related: OS#2542 Change-Id: Ibfbc408c966197682ba2b12d166ade4bfeb7abc2
2019-05-13db_hlr.c: add db_subscr_exists_by_imsi()Oliver Smith5-0/+40
Check if a subscriber exists without generating an error log entry if it does not. This is cheaper than db_subscr_get_by_imsi(), as it does not fetch the subscriber entry. subscriber-create-on-demand will use this function. Related: OS#2542 Change-Id: I63818c0dd4fd22b41dadeeba2a07a651b5454c54
2019-05-13db_hlr.c: db_subscr_create(): add flags argumentOliver Smith7-37/+99
Allow creating new subscribers without giving them access to CS or PS. This will be used by the create-subscriber-on-demand feature. Related: OS#2542 Change-Id: I1a6dd85387723dab5487c53b33d2d9ec6d05d006
2019-05-08use new OSMO_IMSI_BUF_SIZENeels Hofmeyr1-1/+1
Depends: Id11ada4c96b79f7f0ad58185ab7dbf24622fb770 (libosmocore) Change-Id: I8e8fa221e97303df3c6cce96b25d31a53f67b939
2019-05-08osmo-hlr: allow configuring db path from cfg fileNeels Hofmeyr4-3/+25
So far, the cmdline argument was the only way to set a database config file. Add a similar config to VTY as 'hlr' / 'database'. The cmdline arg is stronger than the 'database' cfg item. DB is not reloaded from VTY command. Change-Id: I87b8673324e1e6225afb758fb4963ff3279ea3d8
2019-05-07hlr.c: fix possible msgb memleaks in read_cb()Vadim Yanitskiy1-4/+8
Change-Id: I1226eeb24d7657e2782760fab1b49d5581ab53e2
2019-05-07hlr.c: check the presence of msgb->l2h in read_cb()Vadim Yanitskiy1-6/+6
Checking the presence of msgb->l2h in read_cb_forward() doesn't make sense, since in read_cb() we pass it to osmo_gsup_decode(). Let's rather do this before calling osmo_gsup_decode(). Fix for Change-Id: Ia4f345abc877baaf0a8f73b8988e6514d9589bf5 Change-Id: I69a3d31aacbbb1abef3d83e42e46c899fe2f914b
2019-05-07hlr.c: fix: properly print the original message type in read_cb_forward()Vadim Yanitskiy1-1/+2
Printing 'OSMO_GSUP_MSGT_E_ROUTING_ERROR' in routing error messages instead of the original message type may be confusing. Let's store the original message type, and change just before sending. Fix for Change-Id: Ia4f345abc877baaf0a8f73b8988e6514d9589bf5 Change-Id: Ic1db1e089fc0f8e03653a9f05058e95d2adaee39
2019-05-07hlr.c: fix: also store the session state in read_cb_forward()Vadim Yanitskiy1-0/+1
If the session state is not set (OSMO_GSUP_SESSION_STATE_NONE), osmo_gsup_encode() would omit the OSMO_GSUP_SESSION_ID_IE. Fix for Change-Id: Ia4f345abc877baaf0a8f73b8988e6514d9589bf5 Change-Id: Idcd209a59d1ee5230104f3101740140d366b0646
2019-04-18hlr.c: forward GSUP messages between clientsOliver Smith1-0/+79
Allow clients to forward any GSUP message between clients. Determine the sender and receiver from the new {source,dest}_name{,_len} IEs. Reject messages with a forged source name. This will be used for the inter-MSC handover. Depends: Ic00b0601eacff6d72927cea51767801142ee75db (libosmocore.git) Related: OS#3793 Change-Id: Ia4f345abc877baaf0a8f73b8988e6514d9589bf5
2019-04-18add missing error log: invalid IMSINeels Hofmeyr1-1/+3
Change-Id: I65e9ecac06dc6d1abb9802d621c385d3b4fab83a
2019-04-18fix error logging for GSUP routeNeels Hofmeyr1-1/+1
The addr may not be nul terminated. Change-Id: Ie4def16008af573ed2e1367d9da50c3d2b5a71ef
2019-04-11USSD: don't use gsm0480_msgb_alloc_name()Oliver Smith1-1/+1
We have nothing to do with GSM 04.80 at the HLR - it's only used to encapsulate the SS payload between MS and MSC. This is not that critical, but may be misleading. Also, gsm0480_msgb_alloc_name() allocates a smaller buffer: return msgb_alloc_headroom(1024, 128, name); than osmo_gsup_client_msgb_alloc() does: return msgb_alloc_headroom(4000, 64, __func__); Change-Id: Icdab40c6a933888eb9f51bee9c5264c8919dbf7b
2019-04-09USSD: save MO USSD's originating MSC's vlr_numberOliver Smith3-14/+53
Save the source IPA name in ss_session, so we can send "invalid IMSI" messages to the originating MSC. Remove the fixed size from ss->vlr_number (we don't know the size of the IPA name when it does not come from the database). Add ss->vlr_number_len to give osmo_gsup_addr_send() the format it expects, and to have one less place in the code where the IPA names are not stored as blob. Looking up the IPA name from struct osmo_gsup_conn could either be done like in osmo_gsup_server_ccm_cb() by reading the IPA IEs (which has a FIXME comment), or by finding the route associated with conn. I went with the latter approach, because it seems cleaner to me. Related: OS#3710 Change-Id: If5a65f471672949192061c5fe396603611123bc1
2019-04-09USSD: fix routing to multiple MSCNeels Hofmeyr1-4/+33
hlr_ussd.c so far hardcoded osmo-msc's default IPA-name and hence was only able to negotiate USSD sessions to - a single osmo-msc - that has no custom IPA-name set. Fix: correctly route USSD to any number of MSC with any custom IPA names. Resolve the right MSC's IPA name from the USSD session's IMSI, using hlr_subscriber->vlr_number to determine the right GSUP peer. Cache it in ss_session->vlr_number to have at most one db hit for routing per session. Related: OS#3710 Change-Id: I18067bfadd33a6bc59a9ee336b6937313826fce3
2019-04-08Cosmetic: gsup_route_find: comment addr, addrlenOliver Smith2-2/+15
Describe the addr, addrlen parameters in gsup_route_find() and (more commonly used) osmo_gsup_addr_send(). Without this description, it is easy to get the parameters wrong and have routes not being found, as shown with debug prints like these: gsup_route_find: addr, addrlen: "MSC-13-37-00-00-00-00", 21 gsup_route_find: comparing with: "MSC-13-37-00-00-00-00\0", 22 Change-Id: Ib79878970bd07caac6eb921af8ae95403b90a4cb
2019-03-19tests: use -no-install libtool flag to avoid ./lt-* scriptsOliver Smith4-0/+7
This ensures that the rpath of the generated binaries is set to use only the just-compiled so-files and not any system-wide installed libraries while avoiding the ugly shell script wrapper. Change-Id: I927561289b17b313d52fb5c1da55e237fc1d33be
2019-03-19hlr.c: properly terminate the process on SIGTERMVadim Yanitskiy1-1/+3
As per the systemd.kill manual, when a service is going to be stopped by systemd, the process will first be terminated via SIGTERM. If then, after a delay, processes still remain, the the termination request is repeated with the SIGKILL. It was observed that osmo-hlr immediately terminates on SIGTERM, leaving the SQLite database open. As a result, several temporary files (such as hlr.db-shm, hlr.db-wal) remain, allowing the further recovery: DDB ERROR <0001> db.c:86 (283) recovered 10 frames from WAL file Let's properly handle SIGTERM in the same way as we handle SIGINT. Change-Id: I1a4a48b95bbaed74ff5a03fb5797a44bdb1fcd3a
2019-02-26hlr.c: move hlr_ctx to the topOliver Smith1-2/+1
Allow all functions to use hlr_ctx, so it can be used by the upcoming read_cb_forward() function in [1]. That new function is placed next to the existing read_cb() function, which is above the current hlr_ctx declaration. [1]: Change-Id: Ia4f345abc877baaf0a8f73b8988e6514d9589bf5 Related: OS#3793 Change-Id: I5edf0a233ff323a63e321a1ca47736b5b212d1bb
2019-02-18Enable statsd supportMax3-0/+8
Change-Id: I00b8aa4e59028a4c1098a3bae034e8d8ddfbe681
2019-02-18Add link to project wiki to .service fileMax1-0/+1
Change-Id: Icd4d1270c1765b8424f6df083318a1b6bc31bdb7
2019-02-14Log ip:port when adding GSUP routesMax1-1/+1
Change-Id: I7202fdf59e763dbca261508685555b324ac7e4c0
2019-02-04hlr.c: replace deprecated osmo_gsup_get_err_msg_type()Oliver Smith1-7/+1
Use OSMO_GSUP_TO_MSGT_ERROR() instead. The other function has been deprecated in [1]. Remove the < 0 return check, because the macro doesn't do any error handling. It relies on all "request" messages having an appropriate "error" message, which is part of the GSUP spec now (see [2]). [1] change-id I46d9f2327791978710e2f90b4d28a3761d723d8f (libosmocore) [2] change-id Iec1b4ce4b7d8eb157406f006e1c4241e8fba2cd6 (osmo-gsm-manuals) Change-Id: I5435ec4c29d6acee814c33499c68d18aaa91d4fb
2019-01-24VTY: integrate IMEIOliver Smith4-15/+152
Display the IMEI in "subscriber ... show", allow showing and modifying subscribers by their IMEI with: "subscriber imei ...". For debug purposes (and to have proper VTY tests), make it possible to change the IMEI with "subscriber ... update imei". IMEIs are saved in the database without the 15th checksum number. When the checksum gets passed, verify it and cut it off. Related: OS#2541 Depends: I02b54cf01a674a1911c5c897fbec02240f88b521 (libosmocore) Change-Id: I1af7b573ca2a1cb22497052665012d9c1acf3b30
2019-01-24VTY tests: fill DB before running testOliver Smith3-60/+65
Create a test_subscriber.vty.sql file with a dummy entry that has the ID 100. All entries created in test_subscriber.vty have an ID > 100 now. This will be used in follow-up commit [1] to create a database entry with an invalid IMEI value to test the related error handling code path (that entry could not be created through the VTY). [1]: change-id I1af7b573ca2a1cb22497052665012d9c1acf3b30 "VTY: integrate IMEI" Related: OS#3733 Change-Id: I48a3a503d7ca96798e2d5f70429b5fc36393420e
2019-01-24Optionally store IMEI in subscriber tableOliver Smith4-2/+43
Add VTY config option "store-imei". When it is set, store the IMEI sent from the VLR with CHECK-IMEI in the database. Related: OS#2541 Change-Id: I09274ecbed64224f7ae305e09ede773931da2a57
2019-01-24Add IMEI column to subscriber tableOliver Smith6-14/+203
Extend the database scheme, add imei to the hlr_subscriber struct and create db_subscr_update_imei_by_imsi() and db_subscr_get_by_imei(). The new functions are used in db_test, and in follow-up commits [1], [2]. Upgrade DB schema to version 2. SQLite can only insert new columns at the end of the table, so this happens when upgrading the database. In new databases, the column is placed after the IMEISV column (where it makes more sense in my opinion). This should not have any effect, as we never rely on the order of the columns in the tables. Follow-up commit [1] will make use of this column to save the IMEI as received from the MSC/VLR with the Check-IMEI Procedure. It was decided to use Check-IMEI instead of the recent Automatic Device Detection Procedure (which would send the IMEISV) in OS#3733, because with Check-IMEI we don't need to rely on very recent releases of the specification. [1] change-id I09274ecbed64224f7ae305e09ede773931da2a57 "Optionally store IMEI in subscriber table" [2] change-id I1af7b573ca2a1cb22497052665012d9c1acf3b30 "VTY: integrate IMEI" Depends: Id2d2a3a93b033bafc74c62e15297034bf4aafe61 (libosmocore) Related: OS#2541 Change-Id: If232c80bea35d5c6864b889ae92d477eeaa3f45d
2019-01-22docs: running: document --db-upgradeOliver Smith1-1/+6
Related: OS#3759 Change-Id: I641fd258091974662d9f63697aea103eaf151d09
2019-01-20Bump version: 0.2.1.55-607c-dirty → 1.0.01.0.0Harald Welte2-5/+77
Change-Id: I696beb6f0b82dfaf664f62066cffbcc94e31b700
2019-01-20test_nodes.vty: Since libosmocore 1.0.0, we only have one spaceHarald Welte0-0/+0
The output of "logging level" was wrongly indented with two speaces, and in commit 0d67f483e2d240089105a4d241cb8c9085e245af of libosmocore, first released as part of libosmcoore-1.0.0 it was fixed. This makes "make check" pass against libosmocore-1.0.0, but not against earlier releases. Change-Id: I2cc12b3f0df19d9055022db41f7f3f2789bd19c6
2019-01-17docs: running: s/OsmoBTS/OsmoHLROliver Smith1-1/+1
Change-Id: Ib4e1c8460dbe0a9b7dca8d2291a5e6c5406180e7
2019-01-17docs: running: same argument order as osmo-hlr -hOliver Smith1-10/+12
Change the Synopsis and Options sections of the Running OsmoHLR chapter to list the arguments in the same order as osmo-hlr. This makes it easier to compare, which options are already documented, and which ones are missing. A follow-up commit will document the missing -U/--db-upgrade option. Change-Id: If866124e9cfb43c6986d458712961713541e03b6
2019-01-15Cosmetic: fix arg desc of db_subscr_update_msisdn_by_imsi()Oliver Smith1-2/+2
Properly note that NULL can only be passed as msisdn, not imsi in that function. Change-Id: I19b6ad0cf6e9a4bfa9bffa447ebfc7bd1bcac361
2019-01-15gitignore: add tests/hlr_vty_test.db*Oliver Smith1-0/+1
Ignore files generated from the VTY test. Change-Id: I8f55f655fd6694ac9db7e6280670d16fad61ee72
2019-01-09Cosmetic: hlr.c: remove confusing indent below ifOliver Smith1-7/+6
Remove a misleading block in rx_upd_loc_req() around the call to lu_op_tx_insert_subscr_data(). At least for me, this made the block look like it belonged to the if statement above (which has no brackets), before I looked more closely at it. Change-Id: I96d3ba4108f4811279caf088a9179afce24e8112
2019-01-07Reply to CHECK-IMEI GSUP messagesOliver Smith1-0/+36
Decode the IMEI from incoming CHECK-IMEI messages, print the IMEI to the log and always send ACK back to the VLR/MSC. In the future, we will not only log the IMEI, but store it in the HLR (OS#2541). This is not the original intention of CHECK-IMEI from the 3GPP spec, but an useful side effect. Depends: I085819df0ea7f3bfeb0cabebb5fd1942a23c6155 (libosmocore) Related: OS#3733 Change-Id: Ib240474b0c3c603ba840cf26babb38a44dfc9364
2018-12-20gsupclient: introduce osmo_gsup_client_enc_send()Vadim Yanitskiy2-0/+39
Several parts of OsmoMSC (e.g. GSM 04.11, 09.11, etc.) are dealing with GSUP message encoding and sending towards OsmoHLR. In order to avoid code duplication, let's have a shared function here. Change-Id: I0589ff27933e9bca2bcf93b8259004935778db8f
2018-12-13contrib: fix makedistcheck with disabled systemdOliver Smith1-1/+2
EXTRA_DIST files need to be distributed, no matter if the systemd option is configured or not. Change-Id: Ic164403189510f3b20ff7906df09c78550735591
2018-12-10display last location update timestamp in vtyStefan Sperling3-0/+44
Read the subscriber's last location update timestamp from the database and display it in the output of 'show subscriber'. For example: OsmoHLR> show subscriber id 1 ID: 1 IMSI: 123456789000000 MSISDN: 543210123456789 VLR number: 712 SGSN number: 5952 last LU seen: Fri Dec 7 11:30:51 2018 UTC While the database stores the timestamp as a string, we convert the timestamp into time_t for internal use. This allows for flexible potential use of the timestamp in contexts other than the VTY in the future. The timestamp displayed in the VTY is created with ctime_r(3). It does not match the format of the raw string in the database: sqlite> select id,last_lu_seen from subscriber; 1|2018-12-07 11:30:51 Related: OS#2838 Change-Id: Ie180c434f02ffec0d4b2f651a73258a8126b2e1a
generated by cgit v1.2.3 (git 2.25.1) at 2024-09-24 19:57:35 +0000