diff options
| author | Neels Hofmeyr <neels@hofmeyr.de> | 2019-10-31 01:19:44 +0100 |
|---|---|---|
| committer | laforge <laforge@osmocom.org> | 2019-11-12 16:23:48 +0000 |
| commit | a8045daeef048ee1181f2a3c9bc15e7cd6c1dfca (patch) | |
| tree | cb34a937ae2fddd83b7036875434bce9f19a0eb3 /tests/db_upgrade/db_upgrade_test.ok | |
| parent | 4359b885d4521fb4b9e6a9b4eae579d0ae857260 (diff) | |
hlr db schema 3: hlr_number -> msc_number
The osmo-hlr DB schema indicates a hlr_number column and references it as 3GPP
TS 23.008 chapter 2.4.6. However, chapter 2.4.6 refers to the "MSC number",
while the "HLR number" is chapter 2.4.7.
Taking a closer look, 2.4.6 says "The MSC number is [...] stored in the HLR",
while 2.4.7 says "The HLR number may be stored in the VLR". As quite obvious,
the HLR does not store the HLR number. This was a typo from the start.
The osmo-hlr code base so far does not use the hlr_number column at all, so we
get away with renaming the column without any effects on the code base.
However, let's rather make this a new schema version to be safe.
Change-Id: I527e8627b24b79f3e9eec32675c7f5a3a6d25440
Diffstat (limited to 'tests/db_upgrade/db_upgrade_test.ok')
| -rw-r--r-- | tests/db_upgrade/db_upgrade_test.ok | 20 |
1 files changed, 10 insertions, 10 deletions
diff --git a/tests/db_upgrade/db_upgrade_test.ok b/tests/db_upgrade/db_upgrade_test.ok index bce3eb4..c1f0f9d 100644 --- a/tests/db_upgrade/db_upgrade_test.ok +++ b/tests/db_upgrade/db_upgrade_test.ok @@ -80,7 +80,7 @@ rc = 0 DMAIN hlr starting DDB using database: <PATH>test.db DDB Database <PATH>test.db' has HLR DB schema version 0 -DDB Database <PATH>test.db' has been upgraded to HLR DB schema version 2 +DDB Database <PATH>test.db' has been upgraded to HLR DB schema version 3 DMAIN Cmdline option --db-check: Database was opened successfully, quitting. Resulting db: @@ -117,7 +117,6 @@ Table: subscriber name|type|notnull|dflt_value|pk ggsn_number|VARCHAR(15)|0||0 gmlc_number|VARCHAR(15)|0||0 -hlr_number|VARCHAR(15)|0||0 id|INTEGER|0||1 imei|VARCHAR(14)|0||0 imeisv|VARCHAR|0||0 @@ -126,6 +125,7 @@ last_lu_seen|TIMESTAMP|0|NULL|0 lmsi|INTEGER|0||0 ms_purged_cs|BOOLEAN|1|0|0 ms_purged_ps|BOOLEAN|1|0|0 +msc_number|VARCHAR(15)|0||0 msisdn|VARCHAR(15)|0||0 nam_cs|BOOLEAN|1|1|0 nam_ps|BOOLEAN|1|1|0 @@ -137,13 +137,13 @@ smsc_number|VARCHAR(15)|0||0 vlr_number|VARCHAR(15)|0||0 Table subscriber contents: -ggsn_number|gmlc_number|hlr_number|id|imei|imeisv|imsi|last_lu_seen|lmsi|ms_purged_cs|ms_purged_ps|msisdn|nam_cs|nam_ps|periodic_lu_tmr|periodic_rau_tau_tmr|sgsn_address|sgsn_number|smsc_number|vlr_number -|||1|||123456789012345|||0|0|098765432109876|1|1||||||MSC-1 -|||2|||111111111|||1|0||1|1|||||| -|||3|||222222222|||0|1|22222|1|1|||||| -|||4|||333333|||0|0|3|0|1|||||| -|||5|||444444444444444|||0|0|4444|1|0|||||| -|||6|||5555555|||0|0|55555555555555|0|0|||||| +ggsn_number|gmlc_number|id|imei|imeisv|imsi|last_lu_seen|lmsi|ms_purged_cs|ms_purged_ps|msc_number|msisdn|nam_cs|nam_ps|periodic_lu_tmr|periodic_rau_tau_tmr|sgsn_address|sgsn_number|smsc_number|vlr_number +||1|||123456789012345|||0|0||098765432109876|1|1||||||MSC-1 +||2|||111111111|||1|0|||1|1|||||| +||3|||222222222|||0|1||22222|1|1|||||| +||4|||333333|||0|0||3|0|1|||||| +||5|||444444444444444|||0|0||4444|1|0|||||| +||6|||5555555|||0|0||55555555555555|0|0|||||| Table: subscriber_apn name|type|notnull|dflt_value|pk @@ -164,5 +164,5 @@ osmo-hlr --database $db --db-check --config-file $srcdir/osmo-hlr.cfg rc = 0 DMAIN hlr starting DDB using database: <PATH>test.db -DDB Database <PATH>test.db' has HLR DB schema version 2 +DDB Database <PATH>test.db' has HLR DB schema version 3 DMAIN Cmdline option --db-check: Database was opened successfully, quitting. |