diff options
| author | Stefan Sperling <ssperling@sysmocom.de> | 2018-04-10 19:26:14 +0200 |
|---|---|---|
| committer | Stefan Sperling <ssperling@sysmocom.de> | 2018-05-02 13:34:38 +0200 |
| commit | 93c5b10310a41f7d7b190d4fc98c859f5fb8584b (patch) | |
| tree | 0f0b586f7eb46052d4080ffe8515e9d060d13eb9 /src/luop.c | |
| parent | ec9440f1bc371fc9b95166e051be642ca3ac1274 (diff) | |
rewrite subscriber_update_notify() without calls into luop
This function relied on implementation details of the luop code.
Port what is necessary for an independent Insert Subscriber Data
Tx operation from the luop code into this function.
A next possible step would be to try to merge both of these
into a common implementation. This will be addressed in a
follow-up change as soon as this change is merged.
The TTCN3 test TC_vty_msisdn_isd is still passing (it currently
triggers the "circuit switched domain" case because it does not
advertise itself as an SGSN in the IPA unit name).
Change-Id: I06c43ece2b48dc63d599000eb6d6d51e08963067
Related: OS#2785
Diffstat (limited to 'src/luop.c')
| -rw-r--r-- | src/luop.c | 12 |
1 files changed, 1 insertions, 11 deletions
@@ -27,7 +27,6 @@ #include <osmocom/core/logging.h> #include <osmocom/gsm/gsm48_ie.h> #include <osmocom/gsm/gsup.h> -#include <osmocom/gsm/apn.h> #include "gsup_server.h" #include "gsup_router.h" @@ -233,7 +232,6 @@ void lu_op_tx_cancel_old(struct lu_operation *luop) void lu_op_tx_insert_subscr_data(struct lu_operation *luop) { struct osmo_gsup_message gsup; - uint8_t apn[APN_MAXLEN]; uint8_t msisdn_enc[43]; /* TODO use constant; TS 24.008 10.5.4.7 */ int l; @@ -259,15 +257,7 @@ void lu_op_tx_insert_subscr_data(struct lu_operation *luop) if (luop->is_ps) { /* FIXME: PDP infos - use more fine-grained access control instead of wildcard APN */ - l = osmo_apn_from_str(apn, sizeof(apn), "*"); - if (l > 0) { - gsup.pdp_infos[0].apn_enc = apn; - gsup.pdp_infos[0].apn_enc_len = l; - gsup.pdp_infos[0].have_info = 1; - gsup.num_pdp_infos = 1; - /* FIXME: use real value: */ - gsup.pdp_infos[0].context_id = 1; - } + osmo_gsup_configure_wildcard_apn(&gsup); } /* Send ISD to new VLR/SGSN */ |