aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorVadim Yanitskiy <axilirator@gmail.com>2018-10-12 21:44:07 +0200
committerVadim Yanitskiy <axilirator@gmail.com>2018-10-12 21:46:11 +0200
commit4a4bdcdf9757e3935499ce11c2c902097cd39776 (patch)
tree4b1dddb4788e0c5f54d18ed1ccc6d0efaca4789e
parentcb364bb429b7d188367e445a2bd2b9d81e416d54 (diff)
hlr_ussd.c: fix: reject 'structured' SS requests
As we don't store any SS related information (e.g. call forwarding preferences) in the database, we don't handle 'structured' SS requests at all. Let's reject them by sending error message with FACILITY_NOT_SUPPORTED code. Change-Id: Ia1317c5d372a42473cce65c0c985103e43be77fd Related: OS#3651
-rw-r--r--src/hlr_ussd.c11
1 files changed, 9 insertions, 2 deletions
diff --git a/src/hlr_ussd.c b/src/hlr_ussd.c
index c96f47c..ba373f3 100644
--- a/src/hlr_ussd.c
+++ b/src/hlr_ussd.c
@@ -399,8 +399,15 @@ static int handle_ss(struct ss_session *ss, const struct osmo_gsup_message *gsup
LOGPSS(ss, LOGL_INFO, "SS CompType=%s, OpCode=%s\n",
gsm0480_comp_type_name(comp_type), gsm0480_op_code_name(req->opcode));
- /* FIXME */
- return 0;
+
+ /**
+ * FIXME: As we don't store any SS related information
+ * (e.g. call forwarding preferences) in the database,
+ * we don't handle "structured" SS requests at all.
+ */
+ LOGPSS(ss, LOGL_NOTICE, "Structured SS requests are not supported, rejecting...\n");
+ ss_tx_error(ss, req->invoke_id, GSM0480_ERR_CODE_FACILITY_NOT_SUPPORTED);
+ return -ENOTSUP;
}
/* Handle a USSD GSUP message for a given SS Session received from VLR or EUSE */