aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorSylvain Munaut <tnt@246tNt.com>2013-07-08 20:07:13 +0200
committerSylvain Munaut <tnt@246tNt.com>2013-07-09 01:10:29 +0200
commit4db4ba7826daf9f33e0b772d96f66de374e5357d (patch)
treedaaeb77b96c3b1d127e7706705fbd5a48e969033
parent4b7a86cfbf2da7bcdb4fee10654a7b8f41be6a2c (diff)
sdr/pi4cxpsk: Rewrite loop logic in _gmr1_pi4cxpsk_freq_err for Coverity
Coverity seems confused because it doesn't see that this loop is going to end exactly after 'n' iterations. Fixes CID 1042965, CID 1042966 Signed-off-by: Sylvain Munaut <tnt@246tNt.com>
-rw-r--r--src/sdr/pi4cxpsk.c4
1 files changed, 3 insertions, 1 deletions
diff --git a/src/sdr/pi4cxpsk.c b/src/sdr/pi4cxpsk.c
index 3af1381..6e27220 100644
--- a/src/sdr/pi4cxpsk.c
+++ b/src/sdr/pi4cxpsk.c
@@ -353,8 +353,10 @@ _gmr1_pi4cxpsk_freq_err(struct gmr1_pi4cxpsk_burst *burst_type,
float pos[n], f;
/* Correlate all 'chunks' */
- for (i=0,csync=burst_type->sync[sync_id]; csync->pos>=0; i++,csync++)
+ for (i=0; i<n; i++)
{
+ csync = &burst_type->sync[sync_id][i];
+
corr[i] = 0.0f;
pos[i] = (float)csync->pos + (float)csync->len / 2.0f;