From b11ed0f1321f0567e6fc2e6eb467e5276932da82 Mon Sep 17 00:00:00 2001 From: Harald Welte Date: Mon, 6 Nov 2017 03:07:26 +0900 Subject: sgsnemu: Make sure buffer has space for terminating-NUL In proc_ipv6_conf_read() we allocatea buffer on the stack but forgot the terminating NUL byte. Change-Id: I54126d8bc08c137859f2de4b47ef23fc0714fdd7 Fixes: Coverity CID#178641 --- sgsnemu/sgsnemu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sgsnemu/sgsnemu.c b/sgsnemu/sgsnemu.c index c7ca494..0b0fba6 100644 --- a/sgsnemu/sgsnemu.c +++ b/sgsnemu/sgsnemu.c @@ -985,7 +985,7 @@ out: static char *proc_ipv6_conf_read(const char *dev, const char *file) { const char *fmt = "/proc/sys/net/ipv6/conf/%s/%s"; - char path[strlen(fmt) + strlen(dev) + strlen(file)]; + char path[strlen(fmt) + strlen(dev) + strlen(file)+1]; snprintf(path, sizeof(path), fmt, dev, file); return proc_read(path); } -- cgit v1.2.3