diff options
| author | Oliver Smith <osmith@sysmocom.de> | 2021-12-01 10:03:17 +0100 |
|---|---|---|
| committer | Oliver Smith <osmith@sysmocom.de> | 2021-12-01 10:05:09 +0100 |
| commit | 78c08a33bd5b98cfe1271f77a8ef8d6b7db3180f (patch) | |
| tree | a4ee55dc20738d3d9a8330296ee6049e637af79c | |
| parent | cccd0cdd084a68b67d22a903540d4a699ac376db (diff) | |
lint: checkpatch_osmo: ignore UNNECESSARY_BREAK
Not necessarily followed in Osmocom code, as Daniel wrote:
> The lint complains about this break, I don't agree with it though.
> Without we're one (or two) refactors away from an unintended
> fall-through
Related: OS#5087
Change-Id: I3f106510953b0b1bf70c28ceb55a431c5c03854e
| -rwxr-xr-x | lint/checkpatch/checkpatch_osmo.sh | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/lint/checkpatch/checkpatch_osmo.sh b/lint/checkpatch/checkpatch_osmo.sh index ec9384c..126a8b4 100755 --- a/lint/checkpatch/checkpatch_osmo.sh +++ b/lint/checkpatch/checkpatch_osmo.sh @@ -70,6 +70,7 @@ exclude_paths_project() { # * SPLIT_STRING: we do split long messages over multiple lines # * STRING_FRAGMENTS: sometimes used intentionally to improve readability # * TRAILING_STATEMENTS: not followed, e.g. 'while (osmo_select_main_ctx(1) > 0);' is put in one line +# * UNNECESSARY_BREAK: not followed (see https://gerrit.osmocom.org/c/libosmo-netif/+/26429) # * UNNECESSARY_INT: not followed (see https://gerrit.osmocom.org/c/libosmocore/+/25345) # * UNSPECIFIED_INT: not followed (doesn't seem useful for us) @@ -105,6 +106,7 @@ $SCRIPT_DIR/checkpatch.pl \ --ignore SPLIT_STRING \ --ignore STRING_FRAGMENTS \ --ignore TRAILING_STATEMENTS \ + --ignore UNNECESSARY_BREAK \ --ignore UNNECESSARY_INT \ --ignore UNSPECIFIED_INT \ --max-line-length 120 \ |