From 0698c58ebe1f0e196240dab152f413759c47feb9 Mon Sep 17 00:00:00 2001 From: Vadim Yanitskiy Date: Thu, 26 Nov 2020 21:21:45 +0100 Subject: power_control: implement BS (Downlink) Power Control We already have MS Power Control, which according to 3GPP 45.008 shall be implemented in the MS to minimize the transmit power in the Uplink direction. The BS Power Control may optionally be implemented by the network side for the same purpose. Using Downlink signal measurements reported by the MS, the BSS (either BSC, or BTS) may control Downlink attenuation in a way that the transmit power remains as low as possible, or remains in a specific range corresponding to good RxLev values on the MS side. This change implements autonomous BS Power Control, that can optionally be enabled by the BSC. BS Power Control re-uses parts of the MS Power Control code, so all parameters can be configured in the same way - via the VTY interface or a configuration file. This basically means that features like hysteresis and EWMA based filtering are also available for BS Power Control. The only difference is that RxQual values higher than 0 would trigger the logic to reduce the current attenuation twice. Note that one of the unit tests ('TC_rxlev_max_min') fails, as the power step limitations for raising and lowering look wrong to me, and the related discussion is still ongoing. Change-Id: I5b509e71d5f668b6b8b2abf8053c27f2a7c78451 Related: SYS#4918 --- tests/power/bs_power_loop_test.c | 398 +++++++++++++++++++++++++++++++++++++++ 1 file changed, 398 insertions(+) create mode 100644 tests/power/bs_power_loop_test.c (limited to 'tests/power/bs_power_loop_test.c') diff --git a/tests/power/bs_power_loop_test.c b/tests/power/bs_power_loop_test.c new file mode 100644 index 00000000..bc6b8154 --- /dev/null +++ b/tests/power/bs_power_loop_test.c @@ -0,0 +1,398 @@ +/* + * (C) 2020 by sysmocom - s.m.f.c. GmbH + * Author: Vadim Yanitskiy + * + * All Rights Reserved + * + * This program is free software; you can redistribute it and/or modify + * it under the terms of the GNU Affero General Public License as published by + * the Free Software Foundation; either version 3 of the License, or + * (at your option) any later version. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU General Public License for more details. + * + * You should have received a copy of the GNU Affero General Public License + * along with this program. If not, see . + */ + +#include + +#include +#include +#include + +#include +#include +#include +#include + +#define PWR_TEST_RXLEV_TARGET 30 + +#define DL_MEAS_FULL(rxqual, rxlev) \ + .rxqual_full = rxqual, \ + .rxlev_full = rxlev + +#define DL_MEAS_SUB(rxqual, rxlev) \ + .rxqual_sub = rxqual, \ + .rxlev_sub = rxlev + +#define DL_MEAS_FULL_SUB(rxqual, rxlev) \ + { DL_MEAS_FULL(rxqual, rxlev), \ + DL_MEAS_SUB(rxqual, rxlev) } + +#define DL_MEAS_FULL_SUB_INV(rxqual, rxlev) \ + { DL_MEAS_FULL(rxqual, rxlev), \ + DL_MEAS_SUB(rxqual, rxlev), \ + .invalid = true } + +enum power_test_step_type { + PWR_TEST_ST_IND_MEAS = 0, + PWR_TEST_ST_IND_DUMMY, + PWR_TEST_ST_SET_STATE, + PWR_TEST_ST_SET_PARAMS, + PWR_TEST_ST_ENABLE_DTXD, +}; + +struct power_test_step { + /* Instruction to be performed */ + enum power_test_step_type type; + /* Instruction parameters */ + union { + /* Power Control state */ + struct lchan_power_ctrl_state state; + /* Power Control parameters */ + struct bts_power_ctrl_params params; + /* Indicated DL measurements */ + struct { + uint8_t rxqual_full; + uint8_t rxqual_sub; + uint8_t rxlev_full; + uint8_t rxlev_sub; + bool invalid; + } meas; + }; + /* Expected Tx power reduction */ + uint8_t exp_txred; +}; + +static struct gsm_bts *g_bts = NULL; +static struct gsm_bts_trx *g_trx = NULL; + +static void init_test(const char *name) +{ + if (g_trx != NULL) + talloc_free(g_trx); + if (g_bts != NULL) + talloc_free(g_bts); + + g_bts = talloc_zero(tall_bts_ctx, struct gsm_bts); + OSMO_ASSERT(g_bts != NULL); + + INIT_LLIST_HEAD(&g_bts->trx_list); + g_trx = gsm_bts_trx_alloc(g_bts); + OSMO_ASSERT(g_trx != NULL); + + g_bts->dl_power_ctrl.target = rxlev2dbm(PWR_TEST_RXLEV_TARGET); + g_bts->band = GSM_BAND_900; + g_bts->c0 = g_trx; + + printf("\nStarting test case '%s'\n", name); +} + +static void enc_meas_rep(struct gsm48_hdr *gh, + const unsigned int n, + const struct power_test_step *step) +{ + struct gsm48_meas_res *mr = (struct gsm48_meas_res *) gh->data; + + gh->proto_discr = GSM48_PDISC_RR; + gh->msg_type = GSM48_MT_RR_MEAS_REP; + + *mr = (struct gsm48_meas_res) { + .rxlev_full = step->meas.rxlev_full, + .rxlev_sub = step->meas.rxlev_sub, + .rxqual_full = step->meas.rxqual_full, + .rxqual_sub = step->meas.rxqual_sub, + /* NOTE: inversed logic (1 means invalid) */ + .meas_valid = step->meas.invalid, + }; + + printf("#%02u %s() -> Measurement Results (%svalid): " + "RXLEV-FULL(%02u), RXQUAL-FULL(%u), " + "RXLEV-SUB(%02u), RXQUAL-SUB(%u)\n", + n, __func__, step->meas.invalid ? "in" : "", + mr->rxlev_full, mr->rxqual_full, + mr->rxlev_sub, mr->rxqual_sub); +} + +static int exec_power_step(struct gsm_lchan *lchan, + const unsigned int n, + const struct power_test_step *step) +{ + struct gsm48_hdr *gh; + uint8_t old, new; + uint8_t buf[18]; + + gh = (struct gsm48_hdr *) buf; + + switch (step->type) { + case PWR_TEST_ST_SET_STATE: + printf("#%02u %s() <- State (re)set (current %u dB, max %u dB)\n", + n, __func__, step->state.current, step->state.max); + lchan->bs_power_ctrl = step->state; + return 0; /* we're done */ + case PWR_TEST_ST_SET_PARAMS: + printf("#%02u %s() <- Param (re)set (target %d dBm, hysteresis %u dB, " + "filtering is %sabled)\n", + n, __func__, step->params.target, step->params.hysteresis, + step->params.pf_algo != BTS_PF_ALGO_NONE ? "en" : "dis"); + g_bts->dl_power_ctrl = step->params; + return 0; /* we're done */ + case PWR_TEST_ST_ENABLE_DTXD: + printf("#%02u %s() <- Enable DTXd\n", n, __func__); + lchan->tch.dtx.dl_active = true; + return 0; /* we're done */ + case PWR_TEST_ST_IND_DUMMY: + printf("#%02u %s() <- Dummy block\n", n, __func__); + memset(buf, 0x2b, sizeof(buf)); + break; + case PWR_TEST_ST_IND_MEAS: + enc_meas_rep(gh, n, step); + break; + } + + printf("#%02u lchan_bs_pwr_ctrl() <- UL SACCH: %s\n", + n, osmo_hexdump(buf, sizeof(buf))); + + old = lchan->bs_power_ctrl.current; + lchan_bs_pwr_ctrl(lchan, gh); + new = lchan->bs_power_ctrl.current; + + printf("#%02u lchan_bs_pwr_ctrl() -> BS power reduction: " + "%u -> %u (expected %u)\n", + n, old, new, step->exp_txred); + + return new != step->exp_txred; +} + +static void exec_power_test(const struct power_test_step *steps, + unsigned int num_steps, + const char *name) +{ + unsigned int n; + int rc = 0; + + init_test(name); + + struct gsm_lchan *lchan = &g_trx->ts[0].lchan[0]; + for (n = 0; n < num_steps; n++) + rc |= exec_power_step(lchan, n, &steps[n]); + + printf("Test case verdict: %s\n", rc ? "FAIL" : "SUCCESS"); +} + +/* Verify that the power remains constant in fixed mode. */ +static const struct power_test_step TC_fixed_mode[] = { + /* Initial state: 10 dB, up to 20 dB */ + { .type = PWR_TEST_ST_SET_STATE, + .state = { .current = 10, .max = 2 * 10, .fixed = true } }, + + /* MS indicates random RxQual/RxLev values, which must be ignored */ + { .meas = DL_MEAS_FULL_SUB(0, 63), .exp_txred = 10 }, + { .meas = DL_MEAS_FULL_SUB(7, 0), .exp_txred = 10 }, + { .meas = DL_MEAS_FULL_SUB(0, 30), .exp_txred = 10 }, + { .meas = DL_MEAS_FULL_SUB(1, 30), .exp_txred = 10 }, + { .meas = DL_MEAS_FULL_SUB(1, 50), .exp_txred = 10 }, +}; + +/* Verify that the power remains constant if RxLev equals the target level. */ +static const struct power_test_step TC_rxlev_target[] = { + /* Initial state: 0 dB, up to 20 dB */ + { .type = PWR_TEST_ST_SET_STATE, + .state = { .current = 0, .max = 2 * 10 } }, + + /* MS indicates RxLev values that match the target level */ + { .meas = DL_MEAS_FULL_SUB(0, PWR_TEST_RXLEV_TARGET) }, + { .meas = DL_MEAS_FULL_SUB(0, PWR_TEST_RXLEV_TARGET) }, + { .meas = DL_MEAS_FULL_SUB(0, PWR_TEST_RXLEV_TARGET) }, + { .meas = DL_MEAS_FULL_SUB(0, PWR_TEST_RXLEV_TARGET) }, +}; + +/* Verify that the power is gradually reduced/increased to the + * minimum/maximum if the MS reports high/low RxLev values. */ +static const struct power_test_step TC_rxlev_max_min[] = { + /* Initial state: 0 dB, up to 20 dB */ + { .type = PWR_TEST_ST_SET_STATE, + .state = { .current = 0, .max = 2 * 10 } }, + + /* MS indicates high RxLev values (-50 dBm) */ + { .meas = DL_MEAS_FULL_SUB(0, 60), .exp_txred = 4 }, + { .meas = DL_MEAS_FULL_SUB(0, 60), .exp_txred = 8 }, + { .meas = DL_MEAS_FULL_SUB(0, 60), .exp_txred = 12 }, + { .meas = DL_MEAS_FULL_SUB(0, 60), .exp_txred = 16 }, + { .meas = DL_MEAS_FULL_SUB(0, 60), .exp_txred = 20 }, /* max */ + { .meas = DL_MEAS_FULL_SUB(0, 60), .exp_txred = 20 }, /* max */ + { .meas = DL_MEAS_FULL_SUB(0, 60), .exp_txred = 20 }, /* max */ + + /* MS indicates low RxLev values (-100 dBm) */ + { .meas = DL_MEAS_FULL_SUB(0, 10), .exp_txred = 12 }, + { .meas = DL_MEAS_FULL_SUB(0, 10), .exp_txred = 4 }, + { .meas = DL_MEAS_FULL_SUB(0, 10), .exp_txred = 0 }, /* min */ + { .meas = DL_MEAS_FULL_SUB(0, 10), .exp_txred = 0 }, /* min */ + { .meas = DL_MEAS_FULL_SUB(0, 10), .exp_txred = 0 }, /* min */ +}; + +/* Verify that the logic picks the 'SUB' values in DTXd mode. */ +static const struct power_test_step TC_dtxd_mode[] = { + /* Initial state: 0 dB, up to 20 dB */ + { .type = PWR_TEST_ST_SET_STATE, + .state = { .current = 0, .max = 2 * 10 } }, + + { .meas = DL_MEAS_FULL_SUB(0, PWR_TEST_RXLEV_TARGET) }, + { .meas = DL_MEAS_FULL_SUB(0, PWR_TEST_RXLEV_TARGET) }, + + { .type = PWR_TEST_ST_ENABLE_DTXD }, /* DTXd mode */ + + /* MS indicates target RxLev values as 'SUB', and random as 'FULL' */ + { .meas = { DL_MEAS_FULL(7, 0), DL_MEAS_SUB(0, PWR_TEST_RXLEV_TARGET) } }, + { .meas = { DL_MEAS_FULL(3, 30), DL_MEAS_SUB(0, PWR_TEST_RXLEV_TARGET) } }, + { .meas = { DL_MEAS_FULL(0, 63), DL_MEAS_SUB(0, PWR_TEST_RXLEV_TARGET) } }, +}; + +/* Verify that RxQual > 0 reduces the current attenuation value. */ +static const struct power_test_step TC_rxqual_ber[] = { + /* Initial state: 16 dB, up to 20 dB */ + { .type = PWR_TEST_ST_SET_STATE, + .state = { .current = 16, .max = 2 * 10 } }, + + /* MS indicates target RxLev, and no bit errors */ + { .meas = DL_MEAS_FULL_SUB(0, PWR_TEST_RXLEV_TARGET), .exp_txred = 16 }, + { .meas = DL_MEAS_FULL_SUB(0, PWR_TEST_RXLEV_TARGET), .exp_txred = 16 }, + + /* MS indicates target RxLev, but RxQual values > 0 */ + { .meas = DL_MEAS_FULL_SUB(7, PWR_TEST_RXLEV_TARGET), .exp_txred = 16 / 2 }, + { .meas = DL_MEAS_FULL_SUB(4, PWR_TEST_RXLEV_TARGET), .exp_txred = 16 / 4 }, + { .meas = DL_MEAS_FULL_SUB(1, PWR_TEST_RXLEV_TARGET), .exp_txred = 16 / 8 }, + + /* MS indicates target RxLev, and no bit errors anymore */ + { .meas = DL_MEAS_FULL_SUB(0, PWR_TEST_RXLEV_TARGET), .exp_txred = 16 / 8 }, + { .meas = DL_MEAS_FULL_SUB(0, PWR_TEST_RXLEV_TARGET), .exp_txred = 16 / 8 }, + + /* Reset state: 16 dB, up to 20 dB */ + { .type = PWR_TEST_ST_SET_STATE, + .state = { .current = 16, .max = 2 * 10 } }, + + /* MS indicates target RxLev, but RxQual values > 0 again */ + { .meas = DL_MEAS_FULL_SUB(7, PWR_TEST_RXLEV_TARGET), .exp_txred = 16 / 2 }, + { .meas = DL_MEAS_FULL_SUB(7, PWR_TEST_RXLEV_TARGET), .exp_txred = 16 / 4 }, + { .meas = DL_MEAS_FULL_SUB(7, PWR_TEST_RXLEV_TARGET), .exp_txred = 16 / 8 }, + { .meas = DL_MEAS_FULL_SUB(7, PWR_TEST_RXLEV_TARGET), .exp_txred = 16 / 16 }, + { .meas = DL_MEAS_FULL_SUB(7, PWR_TEST_RXLEV_TARGET), .exp_txred = 16 / 32 }, +}; + +/* Verify that invalid and dummy SACCH blocks are ignored. */ +static const struct power_test_step TC_inval_dummy[] = { + /* Initial state: 16 dB, up to 20 dB */ + { .type = PWR_TEST_ST_SET_STATE, + .state = { .current = 16, .max = 2 * 10 } }, + + /* MS sends invalid measurement results which must be ignored */ + { .meas = DL_MEAS_FULL_SUB_INV(7, 63), .exp_txred = 16 }, + { .meas = DL_MEAS_FULL_SUB_INV(0, 0), .exp_txred = 16 }, + + /* Let's say SMS (SAPI=3) blocks substitute some of the reports */ + { .meas = DL_MEAS_FULL_SUB(0, PWR_TEST_RXLEV_TARGET), .exp_txred = 16 }, + { .type = PWR_TEST_ST_IND_DUMMY, /* not a report */ .exp_txred = 16 }, + { .meas = DL_MEAS_FULL_SUB(0, PWR_TEST_RXLEV_TARGET), .exp_txred = 16 }, + { .type = PWR_TEST_ST_IND_DUMMY, /* not a report */ .exp_txred = 16 }, + { .meas = DL_MEAS_FULL_SUB(0, PWR_TEST_RXLEV_TARGET), .exp_txred = 16 }, +}; + +/* Verify that small deviations from the target do not trigger any changes. */ +static const struct power_test_step TC_rxlev_hyst[] = { + /* Initial state: 16 dB, up to 20 dB */ + { .type = PWR_TEST_ST_SET_STATE, + .state = { .current = 12, .max = 2 * 8 } }, + + /* Hysteresis is not enabled, so small deviations trigger oscillations */ + { .meas = DL_MEAS_FULL_SUB(0, PWR_TEST_RXLEV_TARGET + 1), .exp_txred = 13 }, + { .meas = DL_MEAS_FULL_SUB(0, PWR_TEST_RXLEV_TARGET - 2), .exp_txred = 11 }, + { .meas = DL_MEAS_FULL_SUB(0, PWR_TEST_RXLEV_TARGET + 3), .exp_txred = 14 }, + { .meas = DL_MEAS_FULL_SUB(0, PWR_TEST_RXLEV_TARGET - 2), .exp_txred = 12 }, + + /* Enable hysteresis */ + { .type = PWR_TEST_ST_SET_PARAMS, + .params = { + .target = -110 + PWR_TEST_RXLEV_TARGET, + .hysteresis = 3, + } + }, + + /* Hysteresis is enabled, so small deviations do not trigger any changes */ + { .meas = DL_MEAS_FULL_SUB(0, PWR_TEST_RXLEV_TARGET + 1), .exp_txred = 12 }, + { .meas = DL_MEAS_FULL_SUB(0, PWR_TEST_RXLEV_TARGET - 2), .exp_txred = 12 }, + { .meas = DL_MEAS_FULL_SUB(0, PWR_TEST_RXLEV_TARGET + 3), .exp_txred = 12 }, + { .meas = DL_MEAS_FULL_SUB(0, PWR_TEST_RXLEV_TARGET - 2), .exp_txred = 12 }, +}; + +/* Verify EWMA based power filtering. */ +static const struct power_test_step TC_rxlev_pf_ewma[] = { + /* Initial state: 20 dB, up to 30 dB */ + { .type = PWR_TEST_ST_SET_STATE, + .state = { .current = 16, .max = 2 * 15 } }, + + /* Enable EWMA based power filtering */ + { .type = PWR_TEST_ST_SET_PARAMS, + .params = { + .target = -110 + PWR_TEST_RXLEV_TARGET, /* RxLev 30 */ + .pf_algo = BTS_PF_ALGO_EWMA, + .pf.ewma.alpha = 50, + } + }, + + /* MS indicates target RxLev, power level remains constant */ + { .meas = DL_MEAS_FULL_SUB(0, PWR_TEST_RXLEV_TARGET), .exp_txred = 16 }, + { .meas = DL_MEAS_FULL_SUB(0, PWR_TEST_RXLEV_TARGET), .exp_txred = 16 }, + + /* Avg[t] = (0.5 * 26) + (0.5 * 30) = 28, so delta is 2 */ + { .meas = DL_MEAS_FULL_SUB(0, PWR_TEST_RXLEV_TARGET - 4), .exp_txred = 14 }, + /* Avg[t] = (0.5 * 26) + (0.5 * 28) = 27, so delta is 3 */ + { .meas = DL_MEAS_FULL_SUB(0, PWR_TEST_RXLEV_TARGET - 4), .exp_txred = 11 }, + /* Avg[t] = (0.5 * 35) + (0.5 * 27) = 31, so delta is 1 */ + { .meas = DL_MEAS_FULL_SUB(0, PWR_TEST_RXLEV_TARGET + 5), .exp_txred = 12 }, + /* Avg[t] = (0.5 * 35) + (0.5 * 31) = 33, so delta is 3 */ + { .meas = DL_MEAS_FULL_SUB(0, PWR_TEST_RXLEV_TARGET + 5), .exp_txred = 15 }, +}; + +int main(int argc, char **argv) +{ + printf("Testing BS Power loop...\n"); + + tall_bts_ctx = talloc_named_const(NULL, 1, "OsmoBTS context"); + msgb_talloc_ctx_init(tall_bts_ctx, 0); + + osmo_init_logging2(tall_bts_ctx, &bts_log_info); + osmo_stderr_target->categories[DLOOP].loglevel = LOGL_DEBUG; + osmo_stderr_target->categories[DL1C].loglevel = LOGL_DEBUG; + log_set_print_filename(osmo_stderr_target, 0); + log_set_use_color(osmo_stderr_target, 0); + +#define exec_test(test) \ + exec_power_test(test, ARRAY_SIZE(test), #test) + + exec_test(TC_fixed_mode); + exec_test(TC_rxlev_target); + exec_test(TC_rxlev_max_min); /* FIXME */ + + exec_test(TC_dtxd_mode); + exec_test(TC_rxqual_ber); + exec_test(TC_inval_dummy); + + exec_test(TC_rxlev_hyst); + exec_test(TC_rxlev_pf_ewma); + + return 0; +} -- cgit v1.2.3