From 945c09381d033d142d8e851cd7a4de2e407b61ca Mon Sep 17 00:00:00 2001 From: Philipp Maier Date: Fri, 15 Mar 2019 13:34:34 +0100 Subject: oml: use oml_tx_failure_event_rep() instead of signals to SS_FAIL At some locations in the code a signal to SS_FAIL is dispatched in order to trigger the sending of an OML failure event report in oml.c. This is a bit overcomplicated for the task. Lets use oml_tx_failure_event_rep() to send the failure event reports and lets remove the signal handler for SS_FAIL. Change-Id: Ie4fce1273a19cc14f37ff6fc7582b2945c7e7c47 Related: OS#3843 --- src/common/oml.c | 12 ------------ 1 file changed, 12 deletions(-) (limited to 'src/common/oml.c') diff --git a/src/common/oml.c b/src/common/oml.c index 7ff5967f..c96a893f 100644 --- a/src/common/oml.c +++ b/src/common/oml.c @@ -1493,23 +1493,11 @@ int down_oml(struct gsm_bts *bts, struct msgb *msg) return ret; } -static int handle_fail_sig(unsigned int subsys, unsigned int signal, void *handle, - void *signal_data) -{ - if (signal_data) - oml_tx_failure_event_rep(handle, signal, "%s", signal_data); - else - oml_tx_failure_event_rep(handle, signal, ""); - - return 0; -} - int oml_init(struct gsm_abis_mo *mo) { DEBUGP(DOML, "Initializing OML attribute definitions\n"); tlv_def_patch(&abis_nm_att_tlvdef_ipa_local, &abis_nm_att_tlvdef_ipa); tlv_def_patch(&abis_nm_att_tlvdef_ipa_local, &abis_nm_att_tlvdef); - osmo_signal_register_handler(SS_FAIL, handle_fail_sig, mo); return 0; } -- cgit v1.2.3