From 2ff4592ffc78649bb5c14a213a74569b43da255b Mon Sep 17 00:00:00 2001 From: Pau Espin Pedrol Date: Tue, 15 Sep 2020 13:36:02 +0200 Subject: Fix RadioCarrier OML Operative State Change report not sent on some scenarios Operative state is mainly maintained based on 2 requirements: * phy_link being in CONNECTED state * RSL connection being up and ready However, state change report triggered over OMl towards BSC was only done upon the first event of the two. That means that if for whatever reason the RSL connection was established AFTER the phy_link became CONNECTED (ie receiving RSP POWERON in osmo-bts-trx), then the status towards the BSC would not be updated and hence the BSC would still see the Radio Carrier object as DISABLED. The trx_set_available() function is renamed to trx_operability_update() to keep the logic conditions in one place, and different events triggering a change in state simply call the function and let it handle the new state. Related: SYS#5063 Change-Id: Ic00df9e7278d42bc10c1e1a1c0edde7e13199299 --- include/osmo-bts/bts_trx.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'include/osmo-bts/bts_trx.h') diff --git a/include/osmo-bts/bts_trx.h b/include/osmo-bts/bts_trx.h index d1e13fd8..68937587 100644 --- a/include/osmo-bts/bts_trx.h +++ b/include/osmo-bts/bts_trx.h @@ -57,7 +57,7 @@ char *gsm_trx_name(const struct gsm_bts_trx *trx); const char *gsm_trx_unit_id(struct gsm_bts_trx *trx); int trx_link_estab(struct gsm_bts_trx *trx); -int trx_set_available(struct gsm_bts_trx *trx, int avail); +void trx_operability_update(struct gsm_bts_trx *trx); uint8_t num_agch(struct gsm_bts_trx *trx, const char * arg); bool trx_ms_pwr_ctrl_is_osmo(const struct gsm_bts_trx *trx); -- cgit v1.2.3