From d2065b0c843cfa283bb1685ef997d91a5286ffbd Mon Sep 17 00:00:00 2001 From: Holger Hans Peter Freyther Date: Thu, 11 Jul 2013 10:21:39 +0200 Subject: sysmobts: Enable the RF active LED only when enabling the carrier TODO: check at which point... there is an emission of the BTS... --- src/osmo-bts-sysmo/l1_if.c | 3 +-- src/osmo-bts-sysmo/oml.c | 5 ++++- 2 files changed, 5 insertions(+), 3 deletions(-) diff --git a/src/osmo-bts-sysmo/l1_if.c b/src/osmo-bts-sysmo/l1_if.c index 0af1014c..c4c93929 100644 --- a/src/osmo-bts-sysmo/l1_if.c +++ b/src/osmo-bts-sysmo/l1_if.c @@ -1019,8 +1019,7 @@ static int activate_rf_compl_cb(struct gsm_bts_trx *trx, struct msgb *resp) LOGP(DL1C, LOGL_FATAL, "RF-ACT.conf with status %s\n", get_value_string(femtobts_l1status_names, status)); bts_shutdown(trx->bts, "RF-ACT failure"); - } else - sysmobts_led_set(LED_RF_ACTIVE, 1); + } /* signal availability */ oml_mo_state_chg(&trx->mo, NM_OPSTATE_DISABLED, NM_AVSTATE_OK); diff --git a/src/osmo-bts-sysmo/oml.c b/src/osmo-bts-sysmo/oml.c index faef0258..5ad618a6 100644 --- a/src/osmo-bts-sysmo/oml.c +++ b/src/osmo-bts-sysmo/oml.c @@ -39,6 +39,7 @@ #include "l1_if.h" #include "femtobts.h" #include "utils.h" +#include "hw_misc.h" enum sapi_cmd_type { SAPI_CMD_ACTIVATE, @@ -235,8 +236,10 @@ static int trx_init_compl_cb(struct gsm_bts_trx *trx, struct msgb *l1_msg) if (ic->status != GsmL1_Status_Success) { LOGP(DL1C, LOGL_FATAL, "Rx MPH-INIT.conf status=%s\n", get_value_string(femtobts_l1status_names, ic->status)); + sysmobts_led_set(LED_RF_ACTIVE, 0); bts_shutdown(trx->bts, "MPH-INIT failure"); - } + } else + sysmobts_led_set(LED_RF_ACTIVE, 1); fl1h->hLayer1 = ic->hLayer1; -- cgit v1.2.3