From ad142f84b36e12aac834c90e9d98637b7768b15c Mon Sep 17 00:00:00 2001 From: Holger Hans Peter Freyther Date: Thu, 10 Oct 2013 21:07:04 +0200 Subject: misc: Fix resource leak when the ioctl is failing Fixes: Coverity CID 1040759 --- src/common/abis.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/common/abis.c b/src/common/abis.c index 2017f0a4..bd989c0a 100644 --- a/src/common/abis.c +++ b/src/common/abis.c @@ -177,13 +177,13 @@ static int get_mac_addr(const char *dev_name, uint8_t *mac_out) memset(&ifr, 0, sizeof(ifr)); memcpy(&ifr.ifr_name, dev_name, sizeof(ifr.ifr_name)); rc = ioctl(fd, SIOCGIFHWADDR, &ifr); + close(fd); + if (rc < 0) return rc; memcpy(mac_out, ifr.ifr_hwaddr.sa_data, 6); - close(fd); - return 0; } -- cgit v1.2.3