From 4e9affee0b4e6a6ff10d1ea61b019b7a8e0f5c60 Mon Sep 17 00:00:00 2001 From: Vadim Yanitskiy Date: Wed, 16 Mar 2022 13:04:50 +0300 Subject: osmo-bts-trx: rx_tchh_fn(): mark valid SID frames as such Set the FT (Frame Type) in the ToC (Type-of-Content) section as defined in section 5.2 of RFC 5993. Before this change SID frames had FT = 000 (Good Speech frame), because gsm0503_tch_hr_decode() does not distinguish between speech and SID frames internally. Change-Id: I09cec984bb60c754908126acf0300a2cc602485c Related: SYS#5853 --- src/osmo-bts-trx/sched_lchan_tchh.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/src/osmo-bts-trx/sched_lchan_tchh.c b/src/osmo-bts-trx/sched_lchan_tchh.c index d2ee4f05..5d2c12c9 100644 --- a/src/osmo-bts-trx/sched_lchan_tchh.c +++ b/src/osmo-bts-trx/sched_lchan_tchh.c @@ -149,7 +149,10 @@ int rx_tchh_fn(struct l1sched_ts *l1ts, const struct trx_ul_burst_ind *bi) fn_is_odd, &n_errors, &n_bits_total); if (rc == (GSM_HR_BYTES + 1)) { /* only for valid *speech* frames */ /* gsm0503_tch_hr_decode() prepends a ToC octet (see RFC5993), skip it */ - lchan_set_marker(osmo_hr_check_sid(&tch_data[1], GSM_HR_BYTES), lchan); /* DTXu */ + bool is_sid = osmo_hr_check_sid(&tch_data[1], GSM_HR_BYTES); + if (is_sid) /* Mark SID frames as such: F = 0, FT = 010 */ + tch_data[0] = (0x02 << 4); + lchan_set_marker(is_sid, lchan); /* DTXu */ } break; case GSM48_CMODE_SPEECH_AMR: /* AMR */ -- cgit v1.2.3