diff options
author | Philipp Maier <pmaier@sysmocom.de> | 2020-04-22 12:41:39 +0200 |
---|---|---|
committer | laforge <laforge@osmocom.org> | 2020-04-25 14:03:06 +0000 |
commit | 78a1d3a31a568731f3c253743f0426f51b2df200 (patch) | |
tree | b5d03c396261a9030aaf35c0a04ac6f694bc4440 /tests | |
parent | 58b9f1189843a91f53bce76b3afa9483f89440a0 (diff) |
measurement: remove unecessary is_amr_sid_update parameter
The function ts45008_83_is_sub rougly decides if a frame is a SUB frame
or not. This works by checking the frame number against against lookup
tables. This works fine for codecs where the occurrence of SUB frames is
fixed. However for AMR this is not the case as the DTX periods are
dynamic. Here it is the responsibility of the lower layers (phy,
frame decoding) to tag SUB frames early since making the decision later
based on the frame number is not possible.
The parameter is_amr_sid_update was probably added as a placeholder. It
is set to falls by the callers of the function. Lets remove this
parameter as a late decision if an AMR frame is a SUB frame will never
work.
Change-Id: I125d5ff592218a9e98130a6a7b6bbc6378ce4132
Related: OS#2978
Diffstat (limited to 'tests')
-rw-r--r-- | tests/meas/meas_test.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/tests/meas/meas_test.c b/tests/meas/meas_test.c index c8f06b64..f414b60b 100644 --- a/tests/meas/meas_test.c +++ b/tests/meas/meas_test.c @@ -469,7 +469,7 @@ static void test_ts45008_83_is_sub_single(uint8_t ts, uint8_t ss, bool fr) /* Walk trough the first 100 intervals and check for unexpected * results (false positive and false negative) */ for (i = 0; i < 104 * 100; i++) { - rc = ts45008_83_is_sub(lchan, i, false); + rc = ts45008_83_is_sub(lchan, i); if (rc) { if (!test_ts45008_83_is_sub_is_sacch(i) && !test_ts45008_83_is_sub_is_sub(i, ss)) { |