diff options
author | Pau Espin Pedrol <pespin@sysmocom.de> | 2023-04-03 18:38:55 +0200 |
---|---|---|
committer | Pau Espin Pedrol <pespin@sysmocom.de> | 2023-04-05 13:21:14 +0200 |
commit | c4a17d35ecea72c0b50bc1ac030a6693f8be8262 (patch) | |
tree | d77a5c277dfcb700b8874ca0890f7e3c13b14b04 /src/osmo-bts-sysmo | |
parent | c12bc93db8c968700c18a25d6a85a23f77fbf555 (diff) |
nm: Apply BTS/TRX/TS OML Attributes through NM FSMs
This way we have further control on how to handle the SetAttr meessages
received. For instance, NACK them if the NM object FSMs are not at the expected
correct state.
The originating msgs are now kept owned and freed by the OML layer
(oml.c), and the NM FSMs only uses them and create new OML msgb when
answering with ACK/NACK.
Related: OS#5992
Change-Id: Id68868e25bbf96227ab6459fcd3c9181852ed28e
Diffstat (limited to 'src/osmo-bts-sysmo')
-rw-r--r-- | src/osmo-bts-sysmo/oml.c | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/src/osmo-bts-sysmo/oml.c b/src/osmo-bts-sysmo/oml.c index 67e12750..12b50bfb 100644 --- a/src/osmo-bts-sysmo/oml.c +++ b/src/osmo-bts-sysmo/oml.c @@ -1741,8 +1741,7 @@ int bts_model_apply_oml(struct gsm_bts *bts, struct msgb *msg, rc = osmo_fsm_inst_dispatch(mo->fi, ev_data.cause == 0 ? NM_EV_SETATTR_ACK : NM_EV_SETATTR_NACK, &ev_data); - /* msgb ownsership is transferred to FSM if it received ev: */ - return rc == 0 ? 1 : 0; + return rc; } /* callback from OML */ |