diff options
author | Neels Hofmeyr <nhofmeyr@sysmocom.de> | 2017-02-07 14:37:21 +0100 |
---|---|---|
committer | Ivan Kluchnikov <kluchnikovi@gmail.com> | 2017-02-10 07:27:51 +0000 |
commit | 7a18906cfafc4d73b1c9eb9e527139af6ad938dd (patch) | |
tree | 9a2126dc4440936942e6beb947b6392ec3c1df90 /src/common/vty.c | |
parent | d15dc832c9da401d35300bf4c6d59235ee770bc5 (diff) |
all models: fix vty write: bts_model_config_write_phy
The vty write for phy/inst is broken, leading to a written-out config being
unparsable; fix all of these:
- in common/vty.c, actually call bts_model_config_write_phy_inst().
- in sysmo and lc15 write the phy instance elements in
bts_model_config_write_phy_inst() and not in bts_model_config_write_phy(),
which lead to writing the members above their parent 'instance'.
- sysmo, lc15 and oct omit the bts_model_config_write_phy_inst()
implementation. This did not cause a compilation problem because it
was in fact never called.
- sysmo writes 'clock-source None' when clk_src is zero, leading to unparsable
config (related: OS#1944). Instead omit the 'clock-source' when zero.
- osmo-bts-trx seems to be the only part that lacks nothing, yet it
also didn't work properly because bts_model_config_write_phy_inst()
was never called.
This problem existed since commit d784e50747b8cf0ce505489e1451f75be5ccbd4b
"Introduce new phy_link and phy_instance abstraction"
Change-Id: Icc54fa70045c8fa58e78cf9f788c21a437edfbd4
Diffstat (limited to 'src/common/vty.c')
-rw-r--r-- | src/common/vty.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/src/common/vty.c b/src/common/vty.c index b48afa43..646ac87f 100644 --- a/src/common/vty.c +++ b/src/common/vty.c @@ -358,6 +358,7 @@ static void config_write_phy_single(struct vty *vty, struct phy_link *plink) if (!pinst) break; vty_out(vty, " instance %u%s", pinst->num, VTY_NEWLINE); + bts_model_config_write_phy_inst(vty, pinst); } } |