diff options
| author | Harald Welte <laforge@gnumonks.org> | 2019-02-12 10:19:27 +0100 |
|---|---|---|
| committer | Harald Welte <laforge@gnumonks.org> | 2019-02-23 15:59:18 +0100 |
| commit | de3262fd27624c4f6a7fb5c1b536931932a7e4db (patch) | |
| tree | 35cc520625d4c1cdf242ee55b4a198c22d749e2e /src/common/gsm_data_shared.c | |
| parent | 5eddf98dfc194bc72f0a0694f6c3a02f601c5bf1 (diff) | |
OML: Don't advertise baseband transceiver as UNLOCKED at startup
For some strange historical reason, the baseband transceiver MO was
brought up in state "UNLOCKED".
The object should come up in "locked" state until it's explicitly
unlocked by the BSC.
See Section 6.8.2 of TS 12.21: "If there is yet no administrative state
value explicitly set by the BSC (e.g., at an initialization time), the
object shall be presumed to be administratively locked by default"
Change-Id: Id505594b9f224567566caac84dae2e2ae4477fae
Closes: OS#3790
Diffstat (limited to 'src/common/gsm_data_shared.c')
| -rw-r--r-- | src/common/gsm_data_shared.c | 2 |
1 files changed, 0 insertions, 2 deletions
diff --git a/src/common/gsm_data_shared.c b/src/common/gsm_data_shared.c index 58b2503f..6703095d 100644 --- a/src/common/gsm_data_shared.c +++ b/src/common/gsm_data_shared.c @@ -226,8 +226,6 @@ struct gsm_bts_trx *gsm_bts_trx_alloc(struct gsm_bts *bts) gsm_mo_init(&trx->mo, bts, NM_OC_RADIO_CARRIER, bts->nr, trx->nr, 0xff); - /* FIXME: Why would the TRX come up unlocked? */ - trx->mo.nm_state.administrative = NM_STATE_UNLOCKED; gsm_mo_init(&trx->bb_transc.mo, bts, NM_OC_BASEB_TRANSC, bts->nr, trx->nr, 0xff); |