aboutsummaryrefslogtreecommitdiffstats
path: root/src/common/bts.c
diff options
context:
space:
mode:
authorPau Espin Pedrol <pespin@sysmocom.de>2019-11-14 16:27:25 +0100
committerPau Espin Pedrol <pespin@sysmocom.de>2019-11-14 20:02:45 +0100
commitc693067b7e99a643da673cb3e2a36162cbd0f59c (patch)
tree8b4d003f5b9d69e38d80d5098299d9b9b7a40716 /src/common/bts.c
parentd0a2caa021b66d1f5272004c42c817c068be5dc9 (diff)
Introduce BTS feature BTS_FEAT_MS_PWR_CTRL_DSP
It indicates whether BTS model supports managing an MS Power Control Loop over HW/DSP instead of using the software based osmocom algorithm present in osmo-bts. osmo-bts-trx own loop implementation is considered to be a "DSP/HW" one since it acts on lower layers and interferes with osmocom algorithm since it controls the same end variable "lchan->ms_power_ctrl.current", this way we make sure both aren't enabled at the same time. Old behavior in kept: if common upper-layer algo is not enabled explicitly in VTY (ms-power-control osmo) and bts-trx specific lower layer algo is neither enabled (osmotrx ms-power-loop <xyz>), then no power control is done at all. Related: OS#1851 Change-Id: I49706926b1e962b18791174627bc3cc0cd0cd9d5
Diffstat (limited to 'src/common/bts.c')
-rw-r--r--src/common/bts.c4
1 files changed, 4 insertions, 0 deletions
diff --git a/src/common/bts.c b/src/common/bts.c
index 3809eb3e..da411761 100644
--- a/src/common/bts.c
+++ b/src/common/bts.c
@@ -256,6 +256,10 @@ int bts_trx_init(struct gsm_bts_trx *trx)
tpp->ramp.step_size_mdB = to_mdB(2);
tpp->ramp.step_interval_sec = 1;
+ /* IF BTS model doesn't DSP/HW support MS Power Control Loop, enable osmo algo by default: */
+ if (!gsm_bts_has_feature(trx->bts, BTS_FEAT_MS_PWR_CTRL_DSP))
+ trx->ms_pwr_ctl_soft = true;
+
rc = bts_model_trx_init(trx);
if (rc < 0) {
llist_del(&trx->list);