aboutsummaryrefslogtreecommitdiffstats
path: root/src/common/bts.c
diff options
context:
space:
mode:
authorPau Espin Pedrol <pespin@sysmocom.de>2021-10-04 17:25:11 +0200
committerpespin <pespin@sysmocom.de>2021-10-07 10:47:00 +0000
commit3c32cce0870b883663b7d3e8b0f2c313f736ac84 (patch)
tree91c2975c2b4d5e56e1ea0baec3fdb4fe726d2acb /src/common/bts.c
parent77e014f0612960c1b2cf04401a726362cae962c4 (diff)
MS Power Control Loop: Use P_CON_INTERVAL=2 by default
Have a more stable loop with less temporary oscillations at the expense of increased reaction time. 4 SACCH blocks (P_CON_INTERVAL=2) is the minimum interval to get stable measurements for the last requested MS Power level. With P_CON_INTERVAL=1, are also made during a period with stable power being use to transmit, but the MS Power level used (and announced in MR) is not the last one requested by the BTS, but the one requested in the previous loop iteration. This can make the MS and BTS bounce 2 values forth and back, and create some temporary oscillation. See osmo-bsc User manual section "Power Control" for more information. Related: SYS#5371 Change-Id: I91c505447f68714239a4f033d4f06e91893df201
Diffstat (limited to 'src/common/bts.c')
-rw-r--r--src/common/bts.c4
1 files changed, 2 insertions, 2 deletions
diff --git a/src/common/bts.c b/src/common/bts.c
index 191c331c..b226df20 100644
--- a/src/common/bts.c
+++ b/src/common/bts.c
@@ -340,8 +340,8 @@ int bts_init(struct gsm_bts *bts)
bts->rtp_priority = -1;
/* Default (fall-back) MS/BS Power control parameters */
- bts->bs_dpc_params = power_ctrl_params_def;
- bts->ms_dpc_params = power_ctrl_params_def;
+ power_ctrl_params_def_reset(&bts->bs_dpc_params, true);
+ power_ctrl_params_def_reset(&bts->ms_dpc_params, false);
/* configurable via OML */
bts->load.ccch.load_ind_period = 112;