diff options
| author | Neels Hofmeyr <nhofmeyr@sysmocom.de> | 2017-06-02 19:38:07 +0200 |
|---|---|---|
| committer | Neels Hofmeyr <nhofmeyr@sysmocom.de> | 2017-06-02 22:46:16 +0200 |
| commit | d36b3a84638d6db940387f0e18c98855202f554d (patch) | |
| tree | 9d2d99fb8c17753ad3e79da9f21b8523d80dcec3 /include | |
| parent | e91cd2b0887b0ed41a3bb4c49e4478defd208554 (diff) | |
Revert "Add version to phy_instance"
This reverts commit 9eeb0b1a136fc8c24a86cb4d832c264674c10db0.
This commit caused osmo-gsm-tester test runs for the sysmoBTS to fail with
SIGABRT consistently. See below redmine issues.
In osmo-bts-sysmo/l1_if.c, it uses talloc_asprintf to write to the char
version[MAX_VERSION_LENGTH]; talloc_asprintf() however is intended to work on
string buffers allocated by talloc, and attempts to reallocate version[].
Furthermore, it is not clear why the patch passes a 'data' arg to
app_info_sys_compl_cb() that is not used.
Hence I will revert this instead of trying to fix. Please resolve issues and
re-submit.
Related: OS#2316 OS#1614
Change-Id: I2c9fd5e6739c1750365c0241476ce4b1aa2df3d4
Diffstat (limited to 'include')
| -rw-r--r-- | include/osmo-bts/phy_link.h | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/include/osmo-bts/phy_link.h b/include/osmo-bts/phy_link.h index 4d1dadb1..e8fd7eb7 100644 --- a/include/osmo-bts/phy_link.h +++ b/include/osmo-bts/phy_link.h @@ -75,7 +75,7 @@ struct phy_instance { struct llist_head list; int num; char *description; - char version[MAX_VERSION_LENGTH]; + /* pointer to the PHY link to which we belong */ struct phy_link *phy_link; |