diff options
author | Harald Welte <laforge@gnumonks.org> | 2018-02-23 19:53:16 +0100 |
---|---|---|
committer | Harald Welte <laforge@gnumonks.org> | 2018-02-23 19:57:20 +0100 |
commit | 2de8f6c7ec3d7a2fd1520c09a5b4ba2a4a5b9248 (patch) | |
tree | 59b60d85bd68a8e27315cbb84ca996c3b845d645 /include | |
parent | b82b81b256b7e98872065600fc4e0daf6c0d430a (diff) |
Revert "measurement: fix measurement computation"
This reverts commit d5fdcfe6d95f52fb76c4f4201969347a062fc9fd, which
introduces a new function lchan_meas_update_ordered_TA whose
functionality I still haven't yet managed to fully understand. It
appears to be adjusting the requested timing advance (lchan->rqd_ta) but
outside osmo-bts-trx/loops.c code. This is odd, as rqd_ta is a state
variable of that loops.c code.
So for one part, it is a failure of encapsulation. The TA loop code
should be self-contained, particularly as it is only used for
omso-bts-trx, and not for the other BTS models. The new
lchan_meas_update_ordered_TA() function is used from common code,
applicable to all BTS models.
The resulting interaction between loops.c code and this new (now
reverted) function cause the TA value to only ever grow, despite the MS
never moving at all.
Change-Id: I5a5adac6f18f94a5b51758a5ace8ef6ddfd23e80
Related: OS#2989
Diffstat (limited to 'include')
0 files changed, 0 insertions, 0 deletions