diff options
| author | Philipp Maier <pmaier@sysmocom.de> | 2020-03-20 12:43:51 +0100 |
|---|---|---|
| committer | Vadim Yanitskiy <axilirator@gmail.com> | 2020-04-04 20:27:52 +0700 |
| commit | 7f1800832f4130f797f71e115af87196976c27f1 (patch) | |
| tree | ca8734bbe1d26b3378614d1efdc00d3077dbaf06 /include/osmo-bts/scheduler_backend.h | |
| parent | 085872fe85d2a85969d237971adc7de01b61cb40 (diff) | |
scheduler: always call Uplink burst handler on NOPE.ind
When a NOPE indication is received from the TRX normally a separate
handler (.nope_fn) is called. It turned out that calling the Uplink
handler (.ul_fn) on NOPE indications is the usual case, so let's
remove the .nope_fn member and call the Uplink handler directly.
Since a NOPE.ind comes without burst bits, the Uplink handlers must
check bi->burst_len to avoid uninitialized memory access. For some
logical channels (in particular RACH, PDTCH/U, and PTCCH/U) it does
not make sense to call the Uplink handler, so we ignore them.
Change-Id: Ice45d5986610d9bcef2a7e41f0a395ec779e3928
Related: OS#4461
Diffstat (limited to 'include/osmo-bts/scheduler_backend.h')
| -rw-r--r-- | include/osmo-bts/scheduler_backend.h | 2 |
1 files changed, 0 insertions, 2 deletions
diff --git a/include/osmo-bts/scheduler_backend.h b/include/osmo-bts/scheduler_backend.h index aa2d6e9e..4959853e 100644 --- a/include/osmo-bts/scheduler_backend.h +++ b/include/osmo-bts/scheduler_backend.h @@ -31,8 +31,6 @@ struct trx_chan_desc { trx_sched_dl_func *dl_fn; /*! \brief function to call when burst received from PHY */ trx_sched_ul_func *ul_fn; - /*! \brief function to call when NOPE.ind received from PHY */ - trx_sched_ul_func *nope_fn; /*! \brief channel flags, see TRX_CHAN_FLAG_* */ uint8_t flags; }; |