aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorVadim Yanitskiy <axilirator@gmail.com>2019-10-09 04:24:30 +0700
committerlaforge <laforge@osmocom.org>2019-10-09 16:45:48 +0000
commitd73832bc352c97815b57aeb47dcde42afc854086 (patch)
tree4cd9ffaf4654ef9b080fb03317f33cb59bdd1d70
parent2cbdeba5cf55b72bc3e39e1c333efc1a868ccf2f (diff)
L1SAP: use GSMTAP_CHANNEL_PDTCH for PDTCH blocks by default
We don't know whether a data block on PDCH belongs to PDTCH or PACCH without parsing it, because the latter one is being allocated on demand. Let's use GSMTAP_CHANNEL_PDTCH by default, rather than GSMTAP_CHANNEL_PACCH. Change-Id: I7639215ef936a8ac05ca417a91f4e12755f318d4
-rw-r--r--src/common/l1sap.c6
1 files changed, 4 insertions, 2 deletions
diff --git a/src/common/l1sap.c b/src/common/l1sap.c
index 7d403f01..87ef01bc 100644
--- a/src/common/l1sap.c
+++ b/src/common/l1sap.c
@@ -333,8 +333,10 @@ static int gsmtap_pdch(struct osmo_phsap_prim *l1sap, uint8_t *chan_type,
if (L1SAP_IS_PTCCH(fn)) {
*chan_type = GSMTAP_CHANNEL_PTCCH;
*ss = L1SAP_FN2PTCCHBLOCK(fn);
- } else
- *chan_type = GSMTAP_CHANNEL_PACCH;
+ } else {
+ /* TODO: distinguish PACCH */
+ *chan_type = GSMTAP_CHANNEL_PDTCH;
+ }
return 0;
}