aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorHolger Hans Peter Freyther <holger@moiji-mobile.com>2015-01-09 22:06:28 +0100
committerHolger Hans Peter Freyther <holger@moiji-mobile.com>2015-01-10 09:15:27 +0100
commit84e4dd92d454cd58e9cbe127c0d969e248f0e588 (patch)
tree7cf982c9387d11b493caf2a48ac813dba6bef632
parent55da9874c0306516b8f3bb6f1db486a3c9c51fb2 (diff)
sysmobts: Improve some log messages for calib control
* Print the GPS FD that was opened (e.g. to see if it was closed again) * Print the state changes/expectations * Print the correct to be applied. I wondered if I shouldo do a cor = cor * -1.. cor = -cor.. or add CLOCK_CORR(err) macro to use it inside the printf and correction and decided the gain is not worth the risk.
-rw-r--r--src/osmo-bts-sysmo/misc/sysmobts_mgr_calib.c13
1 files changed, 11 insertions, 2 deletions
diff --git a/src/osmo-bts-sysmo/misc/sysmobts_mgr_calib.c b/src/osmo-bts-sysmo/misc/sysmobts_mgr_calib.c
index 41dade09..27c8b4df 100644
--- a/src/osmo-bts-sysmo/misc/sysmobts_mgr_calib.c
+++ b/src/osmo-bts-sysmo/misc/sysmobts_mgr_calib.c
@@ -1,7 +1,7 @@
/* OCXO/TCXO calibration control for SysmoBTS management daemon */
/*
- * (C) 2014 by Holger Hans Peter Freyther
+ * (C) 2014,2015 by Holger Hans Peter Freyther
* (C) 2014 by Harald Welte for the IPA code from the oml router
*
* All Rights Reserved
@@ -157,7 +157,9 @@ static void mgr_gps_open(struct sysmobts_mgr_instance *mgr)
mgr->calib.fix_timeout.data = mgr;
mgr->calib.fix_timeout.cb = mgr_gps_fix_timeout;
osmo_timer_schedule(&mgr->calib.fix_timeout, 60, 0);
- LOGP(DCALIB, LOGL_NOTICE, "Opened the GPSD connection waiting for fix\n");
+ LOGP(DCALIB, LOGL_NOTICE,
+ "Opened the GPSD connection waiting for fix: %d\n",
+ mgr->calib.gpsfd.fd);
}
static void send_ctrl_cmd(struct sysmobts_mgr_instance *mgr,
@@ -264,6 +266,8 @@ static void calib_get_clock_err_cb(void *_data)
{
struct sysmobts_mgr_instance *mgr = _data;
+ LOGP(DCALIB, LOGL_DEBUG,
+ "Requesting current clock-info.\n");
send_get_ctrl_cmd(mgr, "trx.0.clock-info");
}
@@ -289,6 +293,8 @@ static void handle_ctrl_reset_resp(
mgr->calib.timer.cb = calib_get_clock_err_cb;
mgr->calib.timer.data = mgr;
osmo_timer_schedule(&mgr->calib.timer, 60, 0);
+ LOGP(DCALIB, LOGL_DEBUG,
+ "Reset the calibration counter. Waiting 60 seconds.\n");
}
static void handle_ctrl_get_resp(
@@ -334,6 +340,9 @@ static void handle_ctrl_get_resp(
}
/* Now we can finally set the new value */
+ LOGP(DCALIB, LOGL_NOTICE,
+ "Going to apply %d as new clock correction.\n",
+ -cal_err_int);
send_set_ctrl_cmd_int(mgr, "trx.0.clock-correction", -cal_err_int);
mgr->calib.state = CALIB_COR_SET;
}