aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorPhilipp Maier <pmaier@sysmocom.de>2023-08-08 17:01:57 +0200
committerPhilipp Maier <pmaier@sysmocom.de>2023-08-08 17:34:20 +0200
commit086b46a77fea342b9a0a0f77c3a2096d5ffec877 (patch)
tree2c6ab516b28ad0d487da9726008a9348ab960725
parentff085f63c96b7ae9e7477aa8ed14d51ec44e6622 (diff)
pcuif_proto: remove unnecessary members from gsm_pcu_if_data_cnf_dt
The struct gsm_pcu_if_data_cnf_dt was added when the first experiments mit Ericsson RBS base stations were made. It is essentially a copy of gsm_pcu_if_data, where the mamber "data" was replaced with a member "msg_id" (which was originally called "tlli"). Since we didn't know back then which parameters we would still need at some later point we kept all the other parameters. However, to this day we never used the parameters below fn. Even fn was only used for logging purposes, but is now also unused. Let's remove all those unused members. (Since all removed members are at the tail of the struct, compatibility with other programs that use the PCUIF should not break.) Related: OS#5927 Change-Id: I779605858648e2a1c202c37e197a6e32e6ea3786
-rw-r--r--include/osmo-bts/pcuif_proto.h9
1 files changed, 0 insertions, 9 deletions
diff --git a/include/osmo-bts/pcuif_proto.h b/include/osmo-bts/pcuif_proto.h
index 3e3d6cc6..b93822d2 100644
--- a/include/osmo-bts/pcuif_proto.h
+++ b/include/osmo-bts/pcuif_proto.h
@@ -91,15 +91,6 @@ struct gsm_pcu_if_data {
struct gsm_pcu_if_data_cnf_dt {
uint8_t sapi;
uint32_t msg_id;
- uint32_t fn;
- uint16_t arfcn;
- uint8_t trx_nr;
- uint8_t ts_nr;
- uint8_t block_nr;
- int8_t rssi;
- uint16_t ber10k; /* !< \brief BER in units of 0.01% */
- int16_t ta_offs_qbits; /* !< \brief Burst TA Offset in quarter bits */
- int16_t lqual_cb; /* !< \brief Link quality in centiBel */
} __attribute__ ((packed));
struct gsm_pcu_if_rts_req {