aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorVadim Yanitskiy <vyanitskiy@sysmocom.de>2020-10-30 16:44:55 +0700
committerVadim Yanitskiy <vyanitskiy@sysmocom.de>2020-10-30 16:45:43 +0700
commit850607295ca451c7f68233f9a34d4b845b673e87 (patch)
tree959795d79048b59f8aabcda15f68b8a3539dc862
parent07aa8927e1c8565696df593df010c263a1052f58 (diff)
osmo-bts-trx/scheduler: fix comments related to FACCH/H and BFI
-rw-r--r--src/osmo-bts-trx/sched_lchan_tchh.c8
1 files changed, 5 insertions, 3 deletions
diff --git a/src/osmo-bts-trx/sched_lchan_tchh.c b/src/osmo-bts-trx/sched_lchan_tchh.c
index 18d90bbe..c7dac705 100644
--- a/src/osmo-bts-trx/sched_lchan_tchh.c
+++ b/src/osmo-bts-trx/sched_lchan_tchh.c
@@ -119,11 +119,13 @@ int rx_tchh_fn(struct l1sched_trx *l1t, enum trx_chan_type chan,
}
*mask = 0x0;
- /* skip second of two TCH frames of FACCH was received */
+ /* skip decoding of the last 4 bursts of FACCH/H */
if (chan_state->ul_ongoing_facch) {
chan_state->ul_ongoing_facch = 0;
memcpy(*bursts_p, *bursts_p + 232, 232);
memcpy(*bursts_p + 232, *bursts_p + 464, 232);
+ /* we have already sent the first BFI when a FACCH/H frame
+ * was decoded (see below), now send the second one. */
ber10k = 0;
memset(&meas_avg, 0, sizeof(meas_avg));
goto bfi;
@@ -266,8 +268,8 @@ int rx_tchh_fn(struct l1sched_trx *l1t, enum trx_chan_type chan,
meas_avg.ci_cb, ber10k,
PRES_INFO_UNKNOWN);
bfi:
- /* FIXME: a FACCH/H frame replaces two speech frames,
- * so we actually need to send two bad frame indications! */
+ /* A FACCH/H frame replaces two speech frames, so we need to send two BFIs.
+ * One is sent here, another will be sent two bursts later (see above). */
if (rsl_cmode == RSL_CMOD_SPD_SPEECH) {
/* indicate bad frame */
if (lchan->tch.dtx.ul_sid) {