aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorVadim Yanitskiy <vyanitskiy@sysmocom.de>2023-07-13 03:42:03 +0700
committerlaforge <laforge@osmocom.org>2023-07-21 11:12:50 +0000
commit98e5d6f7c6934aafbf0c290b89d7ee8df8eec182 (patch)
treee930d2a23edceef5a1c55fe7f736570a719893e0
parent29fcae86324f5d004574e51c827c90523150e86f (diff)
osmo-bts-trx: document/clarify the meaning of BUFMAX=24
-rw-r--r--include/osmo-bts/scheduler.h2
-rw-r--r--src/osmo-bts-trx/sched_utils.h4
2 files changed, 4 insertions, 2 deletions
diff --git a/include/osmo-bts/scheduler.h b/include/osmo-bts/scheduler.h
index 23d01fb8..94333ea4 100644
--- a/include/osmo-bts/scheduler.h
+++ b/include/osmo-bts/scheduler.h
@@ -132,7 +132,7 @@ struct l1sched_chan_state {
/* Uplink measurements */
struct {
/* Active channel measurements (simple ring buffer) */
- struct l1sched_meas_set buf[24]; /* up to 24 entries */
+ struct l1sched_meas_set buf[24]; /* up to 24 (BUFMAX) entries */
unsigned int current; /* current position */
/* Interference measurements */
diff --git a/src/osmo-bts-trx/sched_utils.h b/src/osmo-bts-trx/sched_utils.h
index 4e8c17e9..20bd6e76 100644
--- a/src/osmo-bts-trx/sched_utils.h
+++ b/src/osmo-bts-trx/sched_utils.h
@@ -26,7 +26,9 @@
/* Burst Payload LENgth (short alias) */
#define BPLEN GSM_NBITS_NB_GMSK_PAYLOAD
-/* Burst BUFfer capacity (in BPLEN units) */
+/* Burst BUFfer capacity (in BPLEN units). Why 24? Because CSD frames
+ * are interleaved over 22 bursts, but on TCH/F we decode every 4th burst,
+ * so it must be a multiple of 4. See also 'doc/trx_sched_tch.txt'. */
#define BUFMAX 24
/* Burst BUFfer position macros */