diff options
| author | Vadim Yanitskiy <vyanitskiy@sysmocom.de> | 2023-03-01 03:00:25 +0700 |
|---|---|---|
| committer | Vadim Yanitskiy <vyanitskiy@sysmocom.de> | 2023-03-01 03:01:46 +0700 |
| commit | dfe96b786f20cfb0913d05cd7b917f3258ba1c20 (patch) | |
| tree | b0568668cde23d03207a8351a1116990615825f7 | |
| parent | d28ce3287fbf0a7adaefa8bf231e7a3b1a93793f (diff) | |
paging_add_imm_ass(): remove meaningless from_pcu argument
A request to send an Immediate Assignment over the PCH (not AGCH)
is always coming from the PCU. It's used for DL TBF assignment.
Change-Id: If4b0aa01532ab65b96201ff8829e724c67df6993
| -rw-r--r-- | include/osmo-bts/paging.h | 4 | ||||
| -rw-r--r-- | src/common/paging.c | 6 | ||||
| -rw-r--r-- | src/common/pcu_sock.c | 2 |
3 files changed, 6 insertions, 6 deletions
diff --git a/include/osmo-bts/paging.h b/include/osmo-bts/paging.h index ef1fc93d..fb50323b 100644 --- a/include/osmo-bts/paging.h +++ b/include/osmo-bts/paging.h @@ -36,8 +36,8 @@ int paging_add_identity(struct paging_state *ps, uint8_t paging_group, const uint8_t *identity_lv, uint8_t chan_needed); /* Add an IMM.ASS message to the paging queue */ -int paging_add_imm_ass(struct paging_state *ps, const uint8_t *data, - uint8_t len, bool from_pcu); +int paging_add_imm_ass(struct paging_state *ps, + const uint8_t *data, uint8_t len); /* generate paging message for given gsm time */ int paging_gen_msg(struct paging_state *ps, uint8_t *out_buf, struct gsm_time *gt, diff --git a/src/common/paging.c b/src/common/paging.c index 54d72635..26ba9b04 100644 --- a/src/common/paging.c +++ b/src/common/paging.c @@ -268,8 +268,8 @@ int paging_add_identity(struct paging_state *ps, uint8_t paging_group, } /* Add an IMM.ASS message to the paging queue */ -int paging_add_imm_ass(struct paging_state *ps, const uint8_t *data, - uint8_t len, bool from_pcu) +int paging_add_imm_ass(struct paging_state *ps, + const uint8_t *data, uint8_t len) { struct llist_head *group_q; struct paging_record *pr; @@ -277,7 +277,7 @@ int paging_add_imm_ass(struct paging_state *ps, const uint8_t *data, check_congestion(ps); - if (ps->cs_priority_active && from_pcu) { + if (ps->cs_priority_active) { LOGP(DPAG, LOGL_NOTICE, "Dropping paging for PS, queue congested (%u)\n", ps->num_paging); rate_ctr_inc2(ps->bts->ctrs, BTS_CTR_PAGING_DROP_PS); diff --git a/src/common/pcu_sock.c b/src/common/pcu_sock.c index 8f8b3afe..bdf5958e 100644 --- a/src/common/pcu_sock.c +++ b/src/common/pcu_sock.c @@ -681,7 +681,7 @@ static int pcu_rx_data_req(struct gsm_bts *bts, uint8_t msg_type, switch (data_req->sapi) { case PCU_IF_SAPI_PCH: - paging_add_imm_ass(bts->paging_state, data_req->data, data_req->len, true); + paging_add_imm_ass(bts->paging_state, data_req->data, data_req->len); break; case PCU_IF_SAPI_AGCH: msg = msgb_alloc(data_req->len, "pcu_agch"); |