From 05893116a4485d4060240a7ebcd4a260c9f29ef1 Mon Sep 17 00:00:00 2001 From: Pablo Neira Ayuso Date: Mon, 7 Aug 2017 14:01:05 +0100 Subject: libmsc: remove dead code in sms_route_mt_sms() The following branch: if (!rc && !gsms->receiver) rc = GSM411_RP_CAUSE_MO_NUM_UNASSIGNED; at the end of sms_route_mt_sms() always evaluates false. Just a bit before, in such function, we have this: if (!gsms->receiver) { ... #ifdef BUILD_SMPP ... #else ... #endif return rc; } So, if there is no receiver, we just stop running code and return the RP cause via the rc variable. Same applies to the smpp_first check under the BUILD_SMPP ifdef (that I have removed in this snippet to keep this commit message small). Change-Id: Ic3502b5b169bc7a73a67fd6ff53d8b6c0dc045c8 --- src/libmsc/gsm_04_11.c | 3 --- 1 file changed, 3 deletions(-) (limited to 'src') diff --git a/src/libmsc/gsm_04_11.c b/src/libmsc/gsm_04_11.c index 315361089..0cd1b653f 100644 --- a/src/libmsc/gsm_04_11.c +++ b/src/libmsc/gsm_04_11.c @@ -358,9 +358,6 @@ try_local: break; } - if (!rc && !gsms->receiver) - rc = GSM411_RP_CAUSE_MO_NUM_UNASSIGNED; - return rc; } -- cgit v1.2.3