From fa3e40e454db1f4612f8eb3bb7faa1d82fe51aad Mon Sep 17 00:00:00 2001 From: Pau Espin Pedrol Date: Thu, 12 May 2022 12:48:24 +0200 Subject: Revert "stats: new trackers for lchan life duration" This reverts commit 5e2ac29703b4b05f202734698fecdb04b4461bd8. This patch was found to be a troublemaker regarding osmo-bsc performance, since it's scheduling one timer every 100ms for each channel. On a BSC with dozens of BTS, each with several TRX, this ends up in a huge amount of timers scheduled in a tight timeframe, which ends up in osmo-bsc spending CPU time getting in and out of the poll() main loop. Related: SYS#5922 Change-Id: Ibd5123e7f04ae8f4eb8f08b63525527f526f0b2c --- src/osmo-bsc/gsm_data.c | 9 --------- 1 file changed, 9 deletions(-) (limited to 'src/osmo-bsc/gsm_data.c') diff --git a/src/osmo-bsc/gsm_data.c b/src/osmo-bsc/gsm_data.c index 3438eafda..22be92db1 100644 --- a/src/osmo-bsc/gsm_data.c +++ b/src/osmo-bsc/gsm_data.c @@ -342,15 +342,6 @@ void lchan_update_name(struct gsm_lchan *lchan) lchan->nr - (lchan->vamos.is_secondary ? ts->max_primary_lchans : 0)); } -/* If the lchan is currently active, return the duration since activation in milliseconds. - * Otherwise return 0. */ -uint64_t gsm_lchan_active_duration_ms(const struct gsm_lchan *lchan) -{ - if (!lchan->activate.concluded) - return 0; - return lchan->active_cc.total_sum / 1000; -} - /* obtain the MO structure for a given object instance */ static inline struct gsm_abis_mo * gsm_objclass2mo(struct gsm_bts *bts, uint8_t obj_class, -- cgit v1.2.3