From ce869c6baa227ccc0756b921eba0c332c563b923 Mon Sep 17 00:00:00 2001 From: Pau Espin Pedrol Date: Thu, 15 Jul 2021 13:28:38 +0200 Subject: _select_sdcch_for_call: Avoid 2nd lchan lookup when finally selecting it We already looked it up, it's not necessary to look it up again by calling lchan_select_by_type(). Let's instead call lchan_select_set_type() directly on the lchan pointer. Related: SYS#5309 Change-Id: I1054c18f58c9e249f263e3e97a365a1fd8b03a93 --- src/osmo-bsc/abis_rsl.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) (limited to 'src/osmo-bsc/abis_rsl.c') diff --git a/src/osmo-bsc/abis_rsl.c b/src/osmo-bsc/abis_rsl.c index 9b6429d5d..c84aeda2b 100644 --- a/src/osmo-bsc/abis_rsl.c +++ b/src/osmo-bsc/abis_rsl.c @@ -1964,8 +1964,7 @@ struct gsm_lchan *_select_sdcch_for_call(struct gsm_bts *bts, const struct chan_ } select_lchan: - /* FIXME: we already have lchan, simply do lchan->type = GSM_LCHAN_SDCCH? Split lchan_select_by_type in 2 functions? */ - lchan = lchan_select_by_type(bts, GSM_LCHAN_SDCCH); + lchan_select_set_type(lchan, GSM_LCHAN_SDCCH); return lchan; } -- cgit v1.2.3