From c53ca915943e29207e40abc79f72ae6a16f3ed66 Mon Sep 17 00:00:00 2001 From: Vadim Yanitskiy Date: Sat, 6 Apr 2019 18:54:39 +0700 Subject: osmo_bsc_lcls.c: cosmetic: make Coverity happy The 'return' that makes Coverity angry can be safely replaced by 'break'. Change-Id: Ib3d7519421319fb0e6d65441bba123b7b01f4556 Fixes: CID#188873 Identical code for different branches Fixes: CID#188850 Identical code for different branches Fixes: CID#188845 Identical code for different branches --- src/osmo-bsc/osmo_bsc_lcls.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/osmo-bsc/osmo_bsc_lcls.c b/src/osmo-bsc/osmo_bsc_lcls.c index c1f62dc78..98c74c7ec 100644 --- a/src/osmo-bsc/osmo_bsc_lcls.c +++ b/src/osmo-bsc/osmo_bsc_lcls.c @@ -388,7 +388,7 @@ static void lcls_no_lcls_fn(struct osmo_fsm_inst *fi, uint32_t event, void *data case LCLS_EV_UPDATE_CFG_CSC: if (lcls_handle_cfg_update(conn, data) != 0) return; - return; + break; case LCLS_EV_APPLY_CFG_CSC: if (conn->lcls.config == GSM0808_LCLS_CFG_NA) return; @@ -426,7 +426,7 @@ static void lcls_not_yet_ls_fn(struct osmo_fsm_inst *fi, uint32_t event, void *d case LCLS_EV_UPDATE_CFG_CSC: if (lcls_handle_cfg_update(conn, data) != 0) return; - return; + break; case LCLS_EV_APPLY_CFG_CSC: if (lcls_enable_possible(conn)) { osmo_fsm_inst_state_chg(fi, ST_LOCALLY_SWITCHED, 0, 0); @@ -471,7 +471,7 @@ static void lcls_not_possible_ls_fn(struct osmo_fsm_inst *fi, uint32_t event, vo case LCLS_EV_UPDATE_CFG_CSC: if (lcls_handle_cfg_update(conn, data) != 0) return; - return; + break; case LCLS_EV_APPLY_CFG_CSC: if (lcls_perform_correlation(conn) != 0) { /* no correlation result: Remain in NOT_POSSIBLE_LS */ -- cgit v1.2.3