From aaf02ba4086b9a28e94092c86ff74e1f9f268b78 Mon Sep 17 00:00:00 2001 From: Neels Hofmeyr Date: Thu, 8 Jul 2021 06:45:37 +0200 Subject: vty 'interference-meas level-bounds': explain duality in ordering Related: SYS#5313 Change-Id: If71e20e95d29e7f03739ee04e1ef429bf8bd51ed --- src/osmo-bsc/bsc_vty.c | 5 +++-- tests/interf_meas.vty | 2 +- 2 files changed, 4 insertions(+), 3 deletions(-) diff --git a/src/osmo-bsc/bsc_vty.c b/src/osmo-bsc/bsc_vty.c index 1eeda3b3f..d76d02d82 100644 --- a/src/osmo-bsc/bsc_vty.c +++ b/src/osmo-bsc/bsc_vty.c @@ -5051,7 +5051,9 @@ DEFUN_USRATTR(cfg_bts_interf_meas_level_bounds, "interference-meas level-bounds " "<-120-0> <-120-0> <-120-0> <-120-0> <-120-0> <-120-0>", "Interference measurement parameters\n" - "Interference level Boundaries\n" + "Interference level Boundaries. 3GPP do not specify whether these should be in ascending or descending" + " order (3GPP TS 48.058 9.3.21 / 3GPP TS 52.021 9.4.25). OsmoBSC supports either ordering, but possibly" + " some BTS models only return meaningful interference levels with one specific ordering.\n" "Interference boundary 0 (dBm)\n" "Interference boundary X1 (dBm)\n" "Interference boundary X2 (dBm)\n" @@ -5064,7 +5066,6 @@ DEFUN_USRATTR(cfg_bts_interf_meas_level_bounds, for (i = 0; i < ARRAY_SIZE(bts->interf_meas_params_cfg.bounds_dbm); i++) { bts->interf_meas_params_cfg.bounds_dbm[i] = abs(atoi(argv[i])); - /* TODO: ensure ascending (or descending?) order */ } return CMD_SUCCESS; } diff --git a/tests/interf_meas.vty b/tests/interf_meas.vty index 76b33e56d..c6d8fb4e9 100644 --- a/tests/interf_meas.vty +++ b/tests/interf_meas.vty @@ -12,7 +12,7 @@ OsmoBSC(config-net-bts)# interference-meas? interference-meas Interference measurement parameters OsmoBSC(config-net-bts)# interference-meas ? avg-period Averaging period (Intave) - level-bounds Interference level Boundaries + level-bounds Interference level Boundaries. 3GPP do not specify whether these should be in ascending or descending order (3GPP TS 48.058 9.3.21 / 3GPP TS 52.021 9.4.25). OsmoBSC supports either ordering, but possibly some BTS models only return meaningful interference levels with one specific ordering. OsmoBSC(config-net-bts)# ### Averaging period OsmoBSC(config-net-bts)# interference-meas avg-period ? -- cgit v1.2.3