From 729980ef4c8c907373b83c34f31fac9621c6e535 Mon Sep 17 00:00:00 2001 From: Pau Espin Pedrol Date: Mon, 5 Jul 2021 17:42:58 +0200 Subject: lchan_fsm: Allow rx LCHAN_EV_RLL_REL_IND in WAIT_RF_RELEASE_ACK As seen in osmo-bsc log during heavy load scenario: <000f> abis_rsl.c:2171 lchan(12-2-6-TCH_H-0)[0x559b880d1f40]{WAIT_RF_RELEASE_ACK}: Event LCHAN_EV_RLL_REL_IND not permitted Related: SYS#5523 Change-Id: Ie307872851490ae4d60c8117a5f4e2d8c2a414d6 --- src/osmo-bsc/lchan_fsm.c | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/src/osmo-bsc/lchan_fsm.c b/src/osmo-bsc/lchan_fsm.c index 635048167..e3b6c837c 100644 --- a/src/osmo-bsc/lchan_fsm.c +++ b/src/osmo-bsc/lchan_fsm.c @@ -1349,6 +1349,13 @@ static void lchan_fsm_wait_rf_release_ack(struct osmo_fsm_inst *fi, uint32_t eve /* ignore late lchan_rtp_fsm release events */ return; + case LCHAN_EV_RLL_REL_IND: + /* let's just ignore this. We are already logging the fact + * that this message was received inside abis_rsl.c. There can + * be any number of reasons why the radio link layer failed. + */ + return; + default: OSMO_ASSERT(false); } @@ -1594,6 +1601,7 @@ static const struct osmo_fsm_state lchan_fsm_states[] = { .action = lchan_fsm_wait_rf_release_ack, .in_event_mask = 0 | S(LCHAN_EV_RSL_RF_CHAN_REL_ACK) + | S(LCHAN_EV_RLL_REL_IND) /* ignore late REL_IND of SAPI[0] */ | S(LCHAN_EV_RTP_RELEASED) /* ignore late lchan_rtp_fsm release events */ , .out_state_mask = 0 -- cgit v1.2.3