From 5950ea55e29f91f6bed8418f86eaea27db8d8eb9 Mon Sep 17 00:00:00 2001 From: Philipp Maier Date: Tue, 8 Aug 2023 16:43:53 +0200 Subject: pcuif_proto: remove unnecessary members from gsm_pcu_if_data_cnf_dt The struct gsm_pcu_if_data_cnf_dt was added when the first experiments mit Ericsson RBS base stations were made. It is essentially a copy of gsm_pcu_if_data, where the mamber "data" was replaced with a member "msg_id" (which was originally called "tlli"). Since we didn't know back then which parameters we would still need at some later point we kept all the other parameters. However, to this day we never used the parameters below fn. Even fn was only used for logging purposes, but is now also unused. Let's remove all those unused members. (Since all removed members are at the tail of the struct, compatibility with other programs that use the PCUIF should not break.) Change-Id: I37845408edd96017b50559964c82b2cdc5e143a7 Related: OS#5927 --- include/osmocom/bsc/pcuif_proto.h | 9 --------- 1 file changed, 9 deletions(-) diff --git a/include/osmocom/bsc/pcuif_proto.h b/include/osmocom/bsc/pcuif_proto.h index 80e3b6d75..d28aec03d 100644 --- a/include/osmocom/bsc/pcuif_proto.h +++ b/include/osmocom/bsc/pcuif_proto.h @@ -97,15 +97,6 @@ struct gsm_pcu_if_data { struct gsm_pcu_if_data_cnf_dt { uint8_t sapi; uint32_t msg_id; - uint32_t fn; - uint16_t arfcn; - uint8_t trx_nr; - uint8_t ts_nr; - uint8_t block_nr; - int8_t rssi; - uint16_t ber10k; /* !< \brief BER in units of 0.01% */ - int16_t ta_offs_qbits; /* !< \brief Burst TA Offset in quarter bits */ - int16_t lqual_cb; /* !< \brief Link quality in centiBel */ } __attribute__ ((packed)); struct gsm_pcu_if_rts_req { -- cgit v1.2.3