diff options
| author | Neels Hofmeyr <neels@hofmeyr.de> | 2021-01-17 19:41:55 +0100 |
|---|---|---|
| committer | neels <nhofmeyr@sysmocom.de> | 2021-01-19 10:50:41 +0000 |
| commit | 360310f37e139b154385dac2418b130bae95718a (patch) | |
| tree | 49a7b73686a441bedcb52d811f683ebc83fdb993 /tests | |
| parent | 18940b7c709c64edb2d49cfa7e4c9b47896e47cd (diff) | |
fix for test_dyn_ts_favor_moving_half_used_tch_h.ho_vty
So far, the test only works because osmo-bsc fails to notice that
occupying the dynamic TS 1 as TCH/F does, overall, not free a TCH/H, but
reduces available TCH/H from 5 to 4 (one TCH/H freed, but two TCH/H lost
from occupying a dynamic TS). An upcoming patch will make osmo-bsc
sensitive for these cross effects between TCH/F and TCH/H when dynamic
timeslots are involved, hence this test needs to be stabilized.
By using a static TCH/F for TS 1 instead of a dynamic timeslot, the dyn
TS cross effect does not occur and this test actually makes sense.
Change-Id: I492ea095cf3e3c3fd186c889166c4ed93ab3a007
Diffstat (limited to 'tests')
| -rw-r--r-- | tests/handover/test_dyn_ts_favor_moving_half_used_tch_h.ho_vty | 12 |
1 files changed, 6 insertions, 6 deletions
diff --git a/tests/handover/test_dyn_ts_favor_moving_half_used_tch_h.ho_vty b/tests/handover/test_dyn_ts_favor_moving_half_used_tch_h.ho_vty index 3d1b009b4..b25cf96a6 100644 --- a/tests/handover/test_dyn_ts_favor_moving_half_used_tch_h.ho_vty +++ b/tests/handover/test_dyn_ts_favor_moving_half_used_tch_h.ho_vty @@ -2,23 +2,23 @@ # The algorithm should notice that this is about moving an lchan within the same cell, so all candidates will remain # with unchanged rxlev after a re-assignment; hence the current rxlev for each candidate should not make a difference. -create-bts trx-count 1 timeslots c+s4 dyn dyn dyn dyn dyn - - +create-bts trx-count 1 timeslots c+s4 TCH/F dyn dyn dyn dyn - - network handover2 min-free-slots tch/h 6 # Test with identical rxlev across lchans (trivial and unrealistic) -set-ts-use trx 0 0 states * pdch TCH/HH TCH/H- TCH/HH pdch - - +set-ts-use trx 0 0 states * - TCH/HH TCH/H- TCH/HH pdch - - meas-rep lchan * * * * rxlev 30 rxqual 0 ta 0 congestion-check expect-ho from lchan 0 0 3 0 to lchan 0 0 1 0 expect-ts-use trx 0 0 states * TCH/F TCH/HH pdch TCH/HH pdch - - # clear measurements for the next run -set-ts-use trx 0 0 states * pdch pdch pdch pdch pdch - - +set-ts-use trx 0 0 states * - pdch pdch pdch pdch - - # Check that a weaker rxlev coming up earlier in the congestion checking loop does not override the favored half-used # TCH/H -set-ts-use trx 0 0 states * pdch TCH/HH TCH/H- TCH/HH pdch - - +set-ts-use trx 0 0 states * - TCH/HH TCH/H- TCH/HH pdch - - meas-rep lchan 0 0 2 1 rxlev 30 rxqual 0 ta 0 meas-rep lchan 0 0 3 0 rxlev 31 rxqual 0 ta 0 meas-rep lchan 0 0 4 0 rxlev 32 rxqual 0 ta 0 @@ -28,11 +28,11 @@ expect-ho from lchan 0 0 3 0 to lchan 0 0 1 0 expect-ts-use trx 0 0 states * TCH/F TCH/HH pdch TCH/HH pdch - - # clear measurements for the next run -set-ts-use trx 0 0 states * pdch pdch pdch pdch pdch - - +set-ts-use trx 0 0 states * - pdch pdch pdch pdch - - # Check that a weaker rxlev coming up later in the congestion checking loop does not override the favored half-used # TCH/H -set-ts-use trx 0 0 states * pdch TCH/HH TCH/H- TCH/HH pdch - - +set-ts-use trx 0 0 states * - TCH/HH TCH/H- TCH/HH pdch - - meas-rep lchan 0 0 2 1 rxlev 34 rxqual 0 ta 0 meas-rep lchan 0 0 3 0 rxlev 33 rxqual 0 ta 0 meas-rep lchan 0 0 4 0 rxlev 32 rxqual 0 ta 0 |