drop all BSC originated USSD notification features

The BSC is the wrong network component to originate USSD messaging, as can be
seen in the hacks in the USSD code: for example, the BSC would send a CM
Service Accept message as if an MSC had accepted the connection, dispatch a
USSD and directly send some RR release message (without proper tear down
messaging like the lchan_fsm does these days). This made sense in the osmo-nitb
world, but by now we are aiming for solid 3GPP compliance. The BSC shall not
originate USSD messages.

Deprecate all VTY and CTRL commands related to USSD:
VTY
 [no] bsc-welcome-text
 [no] bsc-msc-lost-text
 [no] bsc-grace-text
 [no] missing-msc-text
 (the commands with 'no' are ignored, without 'no' lead to an error)
CTRL
 ussd-notify-v1

Drop (already unused) ussd.h.
Drop gsm_04_80.h, gsm_04_80_utils.c, and all calling code.

Drop "RF grace" notification, where osmo-bsc was able to notify active
subscribers that the RF was being turned off.

Change-Id: Iaef6f2e01b4dbf2bff0a0bb50d6851f50ae79f6a

4 files changed, 0 insertions, 65 deletions

diff --git a/tests/bsc/bsc_test.c b/tests/bsc/bsc_test.c
index 5d8711838..164f78fe5 100644
--- a/tests/bsc/bsc_test.c
+++ b/tests/bsc/bsc_test.c
@@ -29,7 +29,6 @@
 
 #include <osmocom/bsc/osmo_bsc.h>
 #include <osmocom/bsc/bsc_msc_data.h>
-#include <osmocom/bsc/gsm_04_80.h>
 
 #include <osmocom/core/application.h>
 #include <osmocom/core/backtrace.h>
diff --git a/tests/codec_pref/codec_pref_test.c b/tests/codec_pref/codec_pref_test.c
index 8bc31cd0e..f163f35a6 100644
--- a/tests/codec_pref/codec_pref_test.c
+++ b/tests/codec_pref/codec_pref_test.c
@@ -22,7 +22,6 @@
 #include <osmocom/bsc/gsm_data.h>
 #include <osmocom/bsc/osmo_bsc.h>
 #include <osmocom/bsc/bsc_msc_data.h>
-#include <osmocom/bsc/gsm_04_80.h>
 #include <osmocom/core/application.h>
 #include <osmocom/bsc/codec_pref.h>
 
diff --git a/tests/handover/Makefile.am b/tests/handover/Makefile.am
index 901d5231e..84865a06d 100644
--- a/tests/handover/Makefile.am
+++ b/tests/handover/Makefile.am
@@ -63,7 +63,6 @@ handover_test_LDADD = \
 	$(top_builddir)/src/osmo-bsc/chan_alloc.o \
 	$(top_builddir)/src/osmo-bsc/codec_pref.o \
 	$(top_builddir)/src/osmo-bsc/gsm_04_08_rr.o \
-	$(top_builddir)/src/osmo-bsc/gsm_04_80_utils.o \
 	$(top_builddir)/src/osmo-bsc/gsm_data.o \
 	$(top_builddir)/src/osmo-bsc/handover_cfg.o \
 	$(top_builddir)/src/osmo-bsc/handover_decision.o \
diff --git a/tests/vty_test_runner.py b/tests/vty_test_runner.py
index a99bf4b63..c96965cdc 100755
--- a/tests/vty_test_runner.py
+++ b/tests/vty_test_runner.py
@@ -135,68 +135,6 @@ class TestVTYBSC(TestVTYGenericBSC):
         self.assertTrue(self.vty.verify("exit", ['']))
         self.assertTrue(self.vty.node() is None)
 
-    def testUssdNotificationsMsc(self):
-        self.vty.enable()
-        self.vty.command("configure terminal")
-        self.vty.command("msc")
-
-        # Test invalid input
-        self.vty.verify("bsc-msc-lost-text", ['% Command incomplete.'])
-        self.vty.verify("bsc-welcome-text", ['% Command incomplete.'])
-        self.vty.verify("bsc-grace-text", ['% Command incomplete.'])
-
-        # Enable USSD notifications
-        self.vty.verify("bsc-msc-lost-text MSC disconnected", [''])
-        self.vty.verify("bsc-welcome-text Hello MS", [''])
-        self.vty.verify("bsc-grace-text In grace period", [''])
-
-        # Verify settings
-        res = self.vty.command("write terminal")
-        self.assertTrue(res.find('bsc-msc-lost-text MSC disconnected') > 0)
-        self.assertEqual(res.find('no bsc-msc-lost-text'), -1)
-        self.assertTrue(res.find('bsc-welcome-text Hello MS') > 0)
-        self.assertEqual(res.find('no bsc-welcome-text'), -1)
-        self.assertTrue(res.find('bsc-grace-text In grace period') > 0)
-        self.assertEqual(res.find('no bsc-grace-text'), -1)
-
-        # Now disable it..
-        self.vty.verify("no bsc-msc-lost-text", [''])
-        self.vty.verify("no bsc-welcome-text", [''])
-        self.vty.verify("no bsc-grace-text", [''])
-
-        # Verify settings
-        res = self.vty.command("write terminal")
-        self.assertEqual(res.find('bsc-msc-lost-text MSC disconnected'), -1)
-        self.assertTrue(res.find('no bsc-msc-lost-text') > 0)
-        self.assertEqual(res.find('bsc-welcome-text Hello MS'), -1)
-        self.assertTrue(res.find('no bsc-welcome-text') > 0)
-        self.assertEqual(res.find('bsc-grace-text In grace period'), -1)
-        self.assertTrue(res.find('no bsc-grace-text') > 0)
-
-    def testUssdNotificationsBsc(self):
-        self.vty.enable()
-        self.vty.command("configure terminal")
-        self.vty.command("bsc")
-
-        # Test invalid input
-        self.vty.verify("missing-msc-text", ['% Command incomplete.'])
-
-        # Enable USSD notifications
-        self.vty.verify("missing-msc-text No MSC found", [''])
-
-        # Verify settings
-        res = self.vty.command("write terminal")
-        self.assertTrue(res.find('missing-msc-text No MSC found') > 0)
-        self.assertEqual(res.find('no missing-msc-text'), -1)
-
-        # Now disable it..
-        self.vty.verify("no missing-msc-text", [''])
-
-        # Verify settings
-        res = self.vty.command("write terminal")
-        self.assertEqual(res.find('missing-msc-text No MSC found'), -1)
-        self.assertTrue(res.find('no missing-msc-text') > 0)
-
     def testNetworkTimezone(self):
         self.vty.enable()
         self.vty.verify("configure terminal", [''])