diff options
| author | Neels Hofmeyr <neels@hofmeyr.de> | 2018-11-06 22:24:07 +0100 |
|---|---|---|
| committer | Neels Hofmeyr <nhofmeyr@sysmocom.de> | 2018-11-14 16:16:30 +0000 |
| commit | 5b1a7d1e9b8b21b4d4fa74cb5e7ffea14fa5fdb2 (patch) | |
| tree | ec73d9f7fd59ad594573e9def7e8a7b5c7687bcf /tests | |
| parent | d30922f7a384947f6766523180cad7b108c9d751 (diff) | |
lchan release: always Deact SACCH
If an lchan is being released and had a SACCH active, there is no reason to
omit the Deact SACCH message ever. All of the callers that passed
do_deact_sacch = false did so for no good reason.
Drop the do_deact_sacch flag everywhere and, when the lchan type matches and
SAPI[0] is still active, simply always send a Deact SACCH message.
The do_deact_sacch flag was carried over from legacy code, by me, mainly
because I never really understood why it was there. I do hope I'm correct now,
asserting that having this flag makes no sense.
Change-Id: Id3301df059582da2377ef82feae554e94fa42035
Diffstat (limited to 'tests')
| -rw-r--r-- | tests/gsm0408/gsm0408_test.c | 2 | ||||
| -rw-r--r-- | tests/handover/handover_test.c | 2 |
2 files changed, 3 insertions, 1 deletions
diff --git a/tests/gsm0408/gsm0408_test.c b/tests/gsm0408/gsm0408_test.c index 1e6a09771..d15e149a2 100644 --- a/tests/gsm0408/gsm0408_test.c +++ b/tests/gsm0408/gsm0408_test.c @@ -986,7 +986,7 @@ void bsc_cipher_mode_compl(struct gsm_subscriber_connection *conn, const char *bsc_subscr_name(struct bsc_subscr *bsub) { return NULL; } -void lchan_release(struct gsm_lchan *lchan, bool do_deact_sacch, bool do_rr_release, +void lchan_release(struct gsm_lchan *lchan, bool do_rr_release, bool err, enum gsm48_rr_cause cause_rr) {} int rsl_data_request(struct msgb *msg, uint8_t link_id) { return 0; } diff --git a/tests/handover/handover_test.c b/tests/handover/handover_test.c index 7cb4086bb..f728c5bd8 100644 --- a/tests/handover/handover_test.c +++ b/tests/handover/handover_test.c @@ -462,6 +462,8 @@ int __wrap_abis_rsl_sendmsg(struct msgb *msg) break; case RSL_MT_IPAC_CRCX: break; + case RSL_MT_DEACTIVATE_SACCH: + break; default: printf("unknown rsl message=0x%x\n", dh->c.msg_type); } |