diff options
| author | Pau Espin Pedrol <pespin@sysmocom.de> | 2022-05-02 19:38:06 +0200 |
|---|---|---|
| committer | Pau Espin Pedrol <pespin@sysmocom.de> | 2022-05-03 10:25:15 +0200 |
| commit | 1ddafb378129aae71a2e000e492e956d98a665cb (patch) | |
| tree | 0b3736aa36c4401aa3ae821e5c8e1fa06516855b /tests | |
| parent | 36595ea7c5c2fa3c8a846c305f1dfce10c5de787 (diff) | |
bts: Properly free ctr/stat when bts object is freed
This was so far workarounded in tests by manually freeing the fields.
However, in follow-up patch the paging queue will also be properly
freed, so free of the counters needs to be previously fixed too so that
counters are freed at the right point of time.
Otherwise, during paging queue flush, counters are used and would crash
because they were freed before the BTS object in each test's bts_del().
Change-Id: Id213e21cf9bfc5439021e459c22ba4704d8cae2b
Diffstat (limited to 'tests')
| -rw-r--r-- | tests/acc/acc_test.c | 2 | ||||
| -rw-r--r-- | tests/gsm0408/gsm0408_test.c | 2 |
2 files changed, 0 insertions, 4 deletions
diff --git a/tests/acc/acc_test.c b/tests/acc/acc_test.c index 1e78f7335..ce3b0cb4d 100644 --- a/tests/acc/acc_test.c +++ b/tests/acc/acc_test.c @@ -58,8 +58,6 @@ static inline struct gsm_bts *_bts_init(struct gsm_network *net, const char *msg #define bts_del(bts) _bts_del(bts, __func__) static inline void _bts_del(struct gsm_bts *bts, const char *msg) { - osmo_stat_item_group_free(bts->bts_statg); - rate_ctr_group_free(bts->bts_ctrs); if (osmo_timer_pending(&bts->acc_mgr.rotate_timer)) osmo_timer_del(&bts->acc_mgr.rotate_timer); if (osmo_timer_pending(&bts->acc_ramp.step_timer)) diff --git a/tests/gsm0408/gsm0408_test.c b/tests/gsm0408/gsm0408_test.c index a7270a4fa..03b2ee1d3 100644 --- a/tests/gsm0408/gsm0408_test.c +++ b/tests/gsm0408/gsm0408_test.c @@ -137,8 +137,6 @@ static inline struct gsm_bts *_bts_init(struct gsm_network *net, const char *msg #define bts_del(bts) _bts_del(bts, __func__) static inline void _bts_del(struct gsm_bts *bts, const char *msg) { - osmo_stat_item_group_free(bts->bts_statg); - rate_ctr_group_free(bts->bts_ctrs); if (osmo_timer_pending(&bts->acc_mgr.rotate_timer)) osmo_timer_del(&bts->acc_mgr.rotate_timer); /* no need to llist_del(&bts->list), we never registered the bts there. */ |