diff options
| author | Vadim Yanitskiy <vyanitskiy@sysmocom.de> | 2022-06-29 00:02:25 +0700 |
|---|---|---|
| committer | fixeria <vyanitskiy@sysmocom.de> | 2022-06-29 11:27:46 +0000 |
| commit | adc3e36a3eba9d7dd4dee3f90a43c30b1e3b074e (patch) | |
| tree | acbe8b74b5559e0174009adb413d387e66565efa /src/osmo-bsc | |
| parent | abbb8bbbc4aa98769d48f53115fd9989a468afa8 (diff) | |
fix uninitialized err pointer passed to osmo_bssap_le_dec()
osmo_bssap_le_dec() dereferences value of the given pointer and
checks it against NULL. The caller must always initialize it.
Change-Id: Idb0e6565e362ce383c833d6bfec4fb39d2985a6b
Fixes: CID#272982, CID#272944
Diffstat (limited to 'src/osmo-bsc')
| -rw-r--r-- | src/osmo-bsc/lb.c | 2 | ||||
| -rw-r--r-- | src/osmo-bsc/lcs_loc_req.c | 2 |
2 files changed, 2 insertions, 2 deletions
diff --git a/src/osmo-bsc/lb.c b/src/osmo-bsc/lb.c index 7c35fa2de..276b0a197 100644 --- a/src/osmo-bsc/lb.c +++ b/src/osmo-bsc/lb.c @@ -100,7 +100,7 @@ static int handle_unitdata_from_smlc(const struct osmo_sccp_addr *smlc_addr, str { struct osmo_ss7_instance *ss7; struct bssap_le_pdu bssap_le; - struct osmo_bssap_le_err *err; + struct osmo_bssap_le_err *err = NULL; struct rate_ctr_group *ctrg = bsc_gsmnet->smlc->ctrs; ss7 = osmo_sccp_get_ss7(osmo_sccp_get_sccp(scu)); diff --git a/src/osmo-bsc/lcs_loc_req.c b/src/osmo-bsc/lcs_loc_req.c index a658da860..d53f2ab1f 100644 --- a/src/osmo-bsc/lcs_loc_req.c +++ b/src/osmo-bsc/lcs_loc_req.c @@ -226,7 +226,7 @@ int lcs_loc_req_rx_bssmap_le(struct gsm_subscriber_connection *conn, struct msgb { struct lcs_loc_req *lcs_loc_req = conn->lcs.loc_req; struct bssap_le_pdu bssap_le; - struct osmo_bssap_le_err *err; + struct osmo_bssap_le_err *err = NULL; struct rate_ctr_group *ctrg = bsc_gsmnet->smlc->ctrs; if (!lcs_loc_req) { |