aboutsummaryrefslogtreecommitdiffstats
path: root/src/osmo-bsc
diff options
context:
space:
mode:
authorPau Espin Pedrol <pespin@sysmocom.de>2019-10-29 13:19:46 +0100
committerPau Espin Pedrol <pespin@sysmocom.de>2019-10-29 13:20:22 +0100
commit60d6d530ac6883db4f5c0394541ad654ddfd526c (patch)
treed9286d9a1258783f6de2de0797d50804c63ecc84 /src/osmo-bsc
parentcc1a7a07c1928cfd356dbd5690b7769d87403239 (diff)
rsl: Send IE MS Power Param to osmocom BTS models only
Since MS Power Param IE content is operator dependant, it's currently not known which kind of content non-osmocom BTS support/allow, so let's avod possibily breaking those BTS until each BTS has been checked separately. Related: OS#1622 Change-Id: If44121222042bdac06c2a5e70f7b35a88b00b27c
Diffstat (limited to 'src/osmo-bsc')
-rw-r--r--src/osmo-bsc/abis_rsl.c12
1 files changed, 10 insertions, 2 deletions
diff --git a/src/osmo-bsc/abis_rsl.c b/src/osmo-bsc/abis_rsl.c
index 6ffa41526..d4917f295 100644
--- a/src/osmo-bsc/abis_rsl.c
+++ b/src/osmo-bsc/abis_rsl.c
@@ -319,7 +319,11 @@ int rsl_chan_ms_power_ctrl(struct gsm_lchan *lchan, unsigned int fpc, int dbm)
msgb_tv_put(msg, RSL_IE_MS_POWER, lchan->ms_power);
/* indicate MS power control to be performed by BTS: */
- msgb_tl_put(msg, RSL_IE_MS_POWER_PARAM);
+ if (bts->type == GSM_BTS_TYPE_OSMOBTS)
+ msgb_tl_put(msg, RSL_IE_MS_POWER_PARAM);
+ /* else: Since IE MS_POWER_PARAM content is operator dependent, it's not
+ known if non-osmocom BTS models will support an empty IE, so let's
+ better skip sending it unless we know for sure what each expects. */
msg->dst = trx->rsl_link;
@@ -548,7 +552,11 @@ int rsl_tx_chan_activ(struct gsm_lchan *lchan, uint8_t act_type, uint8_t ho_ref)
msgb_tv_put(msg, RSL_IE_MS_POWER, lchan->ms_power);
msgb_tv_put(msg, RSL_IE_TIMING_ADVANCE, ta);
/* indicate MS power control to be performed by BTS: */
- msgb_tl_put(msg, RSL_IE_MS_POWER_PARAM);
+ if (bts->type == GSM_BTS_TYPE_OSMOBTS)
+ msgb_tl_put(msg, RSL_IE_MS_POWER_PARAM);
+ /* else: Since IE MS_POWER_PARAM content is operator dependent, it's not
+ known if non-osmocom BTS models will support an empty IE, so let's
+ better skip sending it unless we know for sure what each expects. */
mr_config_for_bts(lchan, msg);